Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c74cad7b-9ea3-5223-8292-3fe1172a9419@mkarcher.dialup.fu-berlin.de>
Date:   Sun, 22 Jan 2023 12:33:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH: 1/1] sh4: avoid spurious gcc warning
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org,
        linux-sh@vger.kernel.org,
        Segher Boessenkool <segher@kernel.crashing.org>,
        Rich Felker <dalias@libc.org>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc:     jakub@gcc.gnu.org
References: <52952170-f1a9-89a0-e307-f974ce2b7977@fu-berlin.de>
 <2085aec3-796b-71c3-7cb2-d4103d3b6175@infradead.org>
From:   Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
In-Reply-To: <2085aec3-796b-71c3-7cb2-d4103d3b6175@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Am 22.01.2023 um 08:00 schrieb Randy Dunlap:
>> -#define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
>> +#define _INTC_ARRAY(a) a, sizeof(a)/(_Generic((a), typeof(NULL): 0xFFFFFFFFU, default: sizeof(*a)))
> s/: / : / in 2 places.
>
> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks for your confirmation! Are you sure about the space before the 
colon? The colon in this case terminates a case descriptor for the 
type-level switch construction using "_Generic". It says: "In case 'a' 
has the 'type of NULL', divide by 0xFFFFFFFFU, in all other cases, 
divide by the size of a single array element". It's not a colon of the 
ternary ?: operator, in which case I would agree with the space before it.

If you confirm that you want a space before the colon in this case as 
well, I'm going to add it, though.

> How far back in gcc versions does this work?

I tested the support of _Generic on Compiler Explorer at godbolt.org. 
This construction is rejected by gcc 4.8, but accepted by gcc 4.9.

Kind regards,
   Michael Karcher