Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934818AbXHZAdb (ORCPT ); Sat, 25 Aug 2007 20:33:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765090AbXHZAdY (ORCPT ); Sat, 25 Aug 2007 20:33:24 -0400 Received: from nic.NetDirect.CA ([216.16.235.2]:39024 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756916AbXHZAdX (ORCPT ); Sat, 25 Aug 2007 20:33:23 -0400 X-Originating-Ip: 72.143.66.27 Date: Sat, 25 Aug 2007 20:23:15 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Jesper Juhl cc: Denys Vlasenko , linux-mtd@lists.infradead.org, David Woodhouse , Linux Kernel Mailing List Subject: Re: [PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c In-Reply-To: <9a8748490708251728h51d51092r11a3562ceb63b2f9@mail.gmail.com> Message-ID: References: <1554af80879a7ef2f78a4d654f23c248203500d9.1187912217.git.jesper.juhl@gmail.com> <5ebfb93eca0dd43cf17876e643079cbcfeb3111c.1187912217.git.jesper.juhl@gmail.com> <200708241141.06358.vda.linux@googlemail.com> <9a8748490708251527n26cc2065n5b8716bd7f65e252@mail.gmail.com> <9a8748490708251728h51d51092r11a3562ceb63b2f9@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-16.444, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00, RCVD_IN_SORBS_DUL 20.00, SARE_SUB_6CONS_WORD 0.36) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 41 On Sun, 26 Aug 2007, Jesper Juhl wrote: > On 26/08/07, Robert P. J. Day wrote: > > i was thinking more along the lines of > > > > msp_parts[i] = kcalloc(pcnt, sizeof(struct mtd_partition), GFP_KERNEL); > > > > which was kind of the obvious implication, no? > > I guess > > > unless there's a reason kcalloc() wouldn't work here, this is > > pretty much what kcalloc() was designed for. > > > When Denys brought up the zeroing thing and mentioned kzalloc() I > did consider kcalloc() instead, but kzalloc() makes this allocation > nicely look like the preceding ones visually and I couldn't convince > myself that kcalloc() would give us any real benefit here. > > What exactely would using kcalloc() over kzalloc() here buy us? technically, nothing. but if you're not going to use kcalloc() when you're explicitly allocating an array of identical objects (that you want zero-filled, as a bonus), then what's the point of ever having defined a kcalloc() routine in the first place? rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/