Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934844AbXHZAgl (ORCPT ); Sat, 25 Aug 2007 20:36:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765090AbXHZAgd (ORCPT ); Sat, 25 Aug 2007 20:36:33 -0400 Received: from wx-out-0506.google.com ([66.249.82.229]:23621 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756916AbXHZAgc (ORCPT ); Sat, 25 Aug 2007 20:36:32 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=uZhd3hm/BJmwO4ocWY52nJQZHipE7Idr6isJ+uDE1/j4QhRe51DEN6SVbS0ouKv1zwiwLhhj53n/ehyNO7zJKPmOCI/cVJsljg6aLQf1j19AqFloNonTl4H34ZYOZfd4fpjCcd3TiGkUmRIYKjM0iynrPOxISjficP1H5Pu7MJg= Message-ID: <9a8748490708251736k5b751998yee72abdc8c4c1b53@mail.gmail.com> Date: Sun, 26 Aug 2007 02:36:32 +0200 From: "Jesper Juhl" To: "Robert P. J. Day" Subject: Re: [PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c Cc: "Denys Vlasenko" , linux-mtd@lists.infradead.org, "David Woodhouse" , "Linux Kernel Mailing List" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1554af80879a7ef2f78a4d654f23c248203500d9.1187912217.git.jesper.juhl@gmail.com> <5ebfb93eca0dd43cf17876e643079cbcfeb3111c.1187912217.git.jesper.juhl@gmail.com> <200708241141.06358.vda.linux@googlemail.com> <9a8748490708251527n26cc2065n5b8716bd7f65e252@mail.gmail.com> <9a8748490708251728h51d51092r11a3562ceb63b2f9@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1851 Lines: 44 On 26/08/07, Robert P. J. Day wrote: > On Sun, 26 Aug 2007, Jesper Juhl wrote: > > > On 26/08/07, Robert P. J. Day wrote: > > > > i was thinking more along the lines of > > > > > > msp_parts[i] = kcalloc(pcnt, sizeof(struct mtd_partition), GFP_KERNEL); > > > > > > which was kind of the obvious implication, no? > > > > I guess > > > > > unless there's a reason kcalloc() wouldn't work here, this is > > > pretty much what kcalloc() was designed for. > > > > > When Denys brought up the zeroing thing and mentioned kzalloc() I > > did consider kcalloc() instead, but kzalloc() makes this allocation > > nicely look like the preceding ones visually and I couldn't convince > > myself that kcalloc() would give us any real benefit here. > > > > What exactely would using kcalloc() over kzalloc() here buy us? > > technically, nothing. but if you're not going to use kcalloc() when > you're explicitly allocating an array of identical objects (that you > want zero-filled, as a bonus), then what's the point of ever having > defined a kcalloc() routine in the first place? > I wonder a bit about that myself... I have found some other issues in that function that I want to fix, so I'll be respinning the patch as a patch series instead - and why not; I'll just go with kcalloc() and see what the maintainers have to say, it's not like I personally care much one way or the other. -- Jesper Juhl Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/