Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755180AbXHZSAp (ORCPT ); Sun, 26 Aug 2007 14:00:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754027AbXHZSAg (ORCPT ); Sun, 26 Aug 2007 14:00:36 -0400 Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10]:49035 "EHLO pd2mo1so.prod.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753628AbXHZSAf (ORCPT ); Sun, 26 Aug 2007 14:00:35 -0400 Date: Sun, 26 Aug 2007 11:59:13 -0600 From: Robert Hancock Subject: Re: [PATCH] Fix boot-time hang on G31/G33 PC In-reply-to: <20070826140743.GF14130@parisc-linux.org> To: Matthew Wilcox Cc: linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org, Jesse Barnes , Greg KH Message-id: <46D1BF71.3020602@shaw.ca> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit References: <20070826015556.GC14130@parisc-linux.org> <46D10099.40401@shaw.ca> <20070826125542.GD14130@parisc-linux.org> <20070826140743.GF14130@parisc-linux.org> User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1475 Lines: 36 Matthew Wilcox wrote: > On Sun, Aug 26, 2007 at 06:55:42AM -0600, Matthew Wilcox wrote: >> On Sat, Aug 25, 2007 at 10:24:57PM -0600, Robert Hancock wrote: >>> We've already got a patch for this in Greg's PCI tree, hopefully it >>> should go in for 2.6.24. >> I haven't seen it. I guess it wasn't sent to the PCI mailing list. >> >> Your patch had two or three problems with it; assuming we're talking >> about the same patch. > > I found > http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f=pci/pci-disable-decode-of-io-memory-during-bar-sizing.patch;h=958ef4e837733206a80f058aee236847eec5fbd8;hb=HEAD > > which has two problems: > > - With a 64-bit BAR, it checks to see if the upper 32 bits represent IO > or memory. You can't do that to the upper 32 bits. > - It does a lot of additional writes to the cmd register; my patch does two > writes per device; yours does two per BAR > > It's also a lot more complex than my patch, IMO. > > Greg, please drop Robert's patch and put mine in instead. Based on looking at your patch it seems OK. The first problem you mentioned with what Jesse and I had there is definitely a valid one. You can add my: Acked-by: Robert Hancock - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/