From: Al Boldi <a1426z@gawab.com>
To: Ingo Molnar <mingo@elte.hu>
Subject: Re: CFS review
Date: Mon, 27 Aug 2007 07:06:41 +0300
User-Agent: KMail/1.5
Cc: Peter Zijlstra <peterz@infradead.org>, Mike Galbraith <efault@gmx.de>,
       Andrew Morton <akpm@linux-foundation.org>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       linux-kernel@vger.kernel.org
References: <200708111344.42934.a1426z@gawab.com> <200708261927.07040.a1426z@gawab.com> <20070826163907.GB12453@elte.hu>
In-Reply-To: <20070826163907.GB12453@elte.hu>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200708270706.41565.a1426z@gawab.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1279
Lines: 38

Ingo Molnar wrote:
> * Al Boldi <a1426z@gawab.com> wrote:
> > > and could you also check 20.4 on 2.6.22.5 perhaps, or very latest
> > > -git? (Peter has experienced smaller spikes with that.)
> >
> > Ok, I tried all your suggestions, but nothing works as smooth as
> > removing __update_curr.
>
> could you send the exact patch that shows what you did?

On 2.6.22.5-v20.3 (not v20.4):

340-    curr->delta_exec += delta_exec;
341-
342-    if (unlikely(curr->delta_exec > sysctl_sched_stat_granularity)) {
343://          __update_curr(cfs_rq, curr);
344-            curr->delta_exec = 0;
345-    }
346-    curr->exec_start = rq_of(cfs_rq)->clock;

> And could you
> also please describe it exactly which aspect of the workload you call
> 'smooth'. Could it be made quantitative somehow?

The 3x gears test shows the startup problem in a really noticeable way.  With 
v20.4 they startup surging and stalling periodically for about 10sec, then 
they are smooth.  With v20.3 + above patch they startup completely smooth.


Thanks!

--
Al
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/