Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965295AbXH0Vva (ORCPT ); Mon, 27 Aug 2007 17:51:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762963AbXH0Vh4 (ORCPT ); Mon, 27 Aug 2007 17:37:56 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:35304 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765633AbXH0Vhv (ORCPT ); Mon, 27 Aug 2007 17:37:51 -0400 Date: Mon, 27 Aug 2007 22:37:47 +0100 From: Christoph Hellwig To: Eugene Teo Cc: linux-kernel@vger.kernel.org, Takashi Iwai , Arjan van de Ven , Christoph Hellwig Subject: Re: [PATCH] clean up exports in fs/{open,read_write}.c Message-ID: <20070827213747.GA17049@infradead.org> Mail-Followup-To: Christoph Hellwig , Eugene Teo , linux-kernel@vger.kernel.org, Takashi Iwai , Arjan van de Ven References: <20070824033310.GA5662@kernel.sg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070824033310.GA5662@kernel.sg> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 766 Lines: 15 On Fri, Aug 24, 2007 at 11:33:10AM +0800, Eugene Teo wrote: > Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use > request_firmware instead of sys_*. Since that is the last driver in the > kernel that uses sys_{read,close}, this patch kills these exports. sys_open > is left exported for sparc64 only. I can't find any spar user of it, so please kill it. In the case a symbol is needed only for a particular architecture it's better to do it in the architecture-specific ksyms file than with an ifdef, btw. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/