Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964981AbXH0WkB (ORCPT ); Mon, 27 Aug 2007 18:40:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753600AbXH0Wjv (ORCPT ); Mon, 27 Aug 2007 18:39:51 -0400 Received: from peabody.ximian.com ([130.57.169.10]:35628 "EHLO peabody.ximian.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbXH0Wjv (ORCPT ); Mon, 27 Aug 2007 18:39:51 -0400 X-Greylist: delayed 402 seconds by postgrey-1.27 at vger.kernel.org; Mon, 27 Aug 2007 18:39:50 EDT Subject: Re: [-mm patch] make "struct menu_governor" static (again) From: Adam Belay To: Adrian Bunk Cc: Andrew Morton , Venkatesh Pallipadi , Shaohua Li , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Brown@vger.kernel.org, Len In-Reply-To: <20070827212703.GI4121@stusta.de> References: <20070822020648.5ea3a612.akpm@linux-foundation.org> <20070827212703.GI4121@stusta.de> Content-Type: text/plain Date: Mon, 27 Aug 2007 18:32:56 -0400 Message-Id: <1188253976.3929.5.camel@callisto.site> Mime-Version: 1.0 X-Mailer: Evolution 2.6.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 41 This is already fixed in the most recent ACPI CPUIDLE tree. Thanks, Adam On Mon, 2007-08-27 at 23:27 +0200, Adrian Bunk wrote: > On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.23-rc2-mm2: > >... > > git-acpi.patch > >... > > git trees > >... > > "struct menu_governor" needlessly again became global. > > Signed-off-by: Adrian Bunk > > --- > cb33b296204127cf50df54b84b2d79e152fb924b > diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c > index f5a8865..8d3fdc5 100644 > --- a/drivers/cpuidle/governors/menu.c > +++ b/drivers/cpuidle/governors/menu.c > @@ -117,7 +117,7 @@ static int menu_enable_device(struct cpuidle_device *dev) > return 0; > } > > -struct cpuidle_governor menu_governor = { > +static struct cpuidle_governor menu_governor = { > .name = "menu", > .rating = 20, > .enable = menu_enable_device, > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/