Message-ID: <46D354DD.6000208@linux.intel.com>
Date: Mon, 27 Aug 2007 15:49:01 -0700
From: Arjan van de Ven <arjan@linux.intel.com>
User-Agent: Thunderbird 1.5 (Windows/20051201)
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>, Eugene Teo <eugeneteo@kernel.sg>,
       linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
       Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] clean up exports in fs/{open,read_write}.c
References: <20070824033310.GA5662@kernel.sg> <20070827213747.GA17049@infradead.org>
In-Reply-To: <20070827213747.GA17049@infradead.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 953
Lines: 24

Christoph Hellwig wrote:
> On Fri, Aug 24, 2007 at 11:33:10AM +0800, Eugene Teo wrote:
>> Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use
>> request_firmware instead of sys_*. Since that is the last driver in the
>> kernel that uses sys_{read,close}, this patch kills these exports. sys_open
>> is left exported for sparc64 only.
> 
> I can't find any spar user of it, so please kill it.  

it's in the solaris compat code which is modular


> In the case a symbol
> is needed only for a particular architecture it's better to do it in the
> architecture-specific ksyms file than with an ifdef, btw.

agreed.
(well if it's only 1 or 2, if it's "half of them" it's obviously a 
different story)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/