From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>,
        Babis Chalios <bchalios@amazon.es>
CC:     Olivia Mackall <olivia@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Jason Wang <jasowang@redhat.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "amit@kernel.org" <amit@kernel.org>,
        "graf@amazon.de" <graf@amazon.de>,
        "Jason@zx2c4.com" <Jason@zx2c4.com>,
        "xmarcalx@amazon.co.uk" <xmarcalx@amazon.co.uk>
Subject: RE: [PATCH 1/2] virtio-rng: implement entropy leak feature
Thread-Topic: [PATCH 1/2] virtio-rng: implement entropy leak feature
Thread-Index: AQHZLDYqz+OzQX/4LkKse2Y5pZYAp66nPh+AgAAqY0A=
Date:   Fri, 20 Jan 2023 15:07:08 +0000
Message-ID: <MW5PR84MB18426587FD27BB152D621BABABC59@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20230119184349.74072-1-bchalios@amazon.es>
 <20230119184349.74072-2-bchalios@amazon.es>
 <20230120072909-mutt-send-email-mst@kernel.org>
In-Reply-To: <20230120072909-mutt-send-email-mst@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Scuez5bpEnoSM48zaINqVhAFHXn6jUBsSOrONSZq5MJDvM8x64s6pWM8ZHqI?=
 =?us-ascii?Q?yRf3gnTFtalQGrJVo4WRDNHq6fmQly8frOv0fa0sI5o2CRUPKDmftimZT1mi?=
 =?us-ascii?Q?xaFc8CrJMUpGT3DkHS7TrcreHUXLHsn+uxVl5nYWViiqW5TbF3nfIzcl5RKk?=
 =?us-ascii?Q?MGR1EsBGvgRRxbw7ZYlyI6wrTOQq/gQnA4q5EUcHGxNejkgcAV5qyBDIWIOn?=
 =?us-ascii?Q?YIsV6LIIP1VGe0ZiWqUgpPXL+RGD4GvicdEKQfRjWvA+3ip9pwj3FTnY8lWK?=
 =?us-ascii?Q?WSA2QoNjRz7q5p1CW9P+Enbjko6QdvnlT5Zb0oNej/KMZ78VkwLtt4QMdIZB?=
 =?us-ascii?Q?jnLrpuQZqWUjiFM5N1GMVSzzuQ4Q8wAEAZ2Jv9e+Jl4o0OPe9Xjt68v6WZbQ?=
 =?us-ascii?Q?mbMDYuyFgcxTuDjjrhfjQeTX03bToBJKqjk+ZAxlTsgs/G3J8hDAp6dJWtYn?=
 =?us-ascii?Q?UWE5xr8Wwf8vfblBJ3dUaDKzVFz8I6+InT/TMEb5vDNR91chjBARSamC5V2o?=
 =?us-ascii?Q?FxVZWtv86lvUXfKdK6sWQXcSMU7f2IMrHprEqq0qEQU5tjnZhBA0bQQ3TxOT?=
 =?us-ascii?Q?ZuSyAP33oiYHIHuiXEoUQAFuUpC6tAbwcWwoMdwaX9IiLvTswacI/QYxtfsQ?=
 =?us-ascii?Q?lZTlV5vZqA3hm7jE9PtAtFJoocbd4hkAwEzS+TKENR54BQJSqFvT1JC+2eGS?=
 =?us-ascii?Q?l1QeSRv0ExDi02qUzLa8ZX/sqol4ngBIBaAXu0GFdZ3f1qe9SXrTHLxAXq/b?=
 =?us-ascii?Q?MjgG+44mLXMwf+8O6JREbDatpEFH25G1rPiA96t3zHJT/r8lITPD19VuU7nr?=
 =?us-ascii?Q?l6o2IhzPdwEQR3VHfY2VENIOK36qx3ZomvjbyRSkJ06OfYFhaGqC39s6Vgq4?=
 =?us-ascii?Q?ACaiKhylNIrnzyE8XZHVqRMSbG9cS6/HZo7EpSj5ZtSBomrt80c+YwvrmXbo?=
 =?us-ascii?Q?93WVnZtse0UakbyHR6wi8HOZH3iN8KWFcPjQyB3MNUz/QZRz7yehg6E0atgb?=
 =?us-ascii?Q?uq0LgsT+33IFurKdJyiDodswv6z5RxMzr/GTYsE3/KOMMZL1nO+SZkS+wNdq?=
 =?us-ascii?Q?4VzaYHMExD1Wi4QS2i1Ao8+ZasyOuynmSWIM5DFLT7GDvnvr3xKpBEmBwdgG?=
 =?us-ascii?Q?wC4cNtZ2NseGwzxyUKHa9iEzvI3p9KiJUtAT/NVWC/4yI5YgWGJdUbRYCaFX?=
 =?us-ascii?Q?eF1vGSYEov3lMzT7WR/RFbi0QFhFm8yyL7zuI4tO0kelnOAp+WIghP8SsFe8?=
 =?us-ascii?Q?Lv4/v1bf0V08X5JQLDwXMnMJAGNi5b/1+K8BOP8T2MYUWXjIPCt6jEMbdHCd?=
 =?us-ascii?Q?1LrA1VA+ZNio377WadNnETN9JMaXXcDohFZUjD4N8uyxODx1Nl7wujgOUwkI?=
 =?us-ascii?Q?L3GOZo5RfMoZC2eGGfmrifNG+s8ZCIoOAUzoWhoPljpMMUulPZoNQKVtKGmT?=
 =?us-ascii?Q?Np8mCJCofcLSOuJtArK1YiUje7R98Y3v6uAnrkybnROVowT8tikHWf8ricTA?=
 =?us-ascii?Q?wZf9vmzrXYBDbiCh/MgoeFRcoFuUwIYqXMEZCva88w0cQ1sMl8fUIPvMm7WO?=
 =?us-ascii?Q?vn6HDiM/6eH+zqwZhn8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 5aec68a5-4c47-4b6c-c8a1-08dafaf7ffc2
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2023 15:07:08.0855
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jV/J/88AG5kHbUtHzLRbImLcS3DD5pgeeF8EKR+iaKun+tPvxVr324lyRFq2W8s+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB1428
X-OriginatorOrg: hpe.com
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-20_09,2023-01-20_01,2022-06-22_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +#include "asm-generic/errno.h"
>=20
> Why are you pulling this in?
> If you really need errno the thing to include
> is linux/errno.h
>=20
> checkpatch has a rule to catch such cases:
>=20
> # warn if <asm/foo.h> is #included and <linux/foo.h> is available and inc=
ludes
> # itself <asm/foo.h> (uses RAW line)

It's only looking for asm, not variations like asm-generic.