Date:   Sun, 22 Jan 2023 14:46:25 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     SeongJae Park <sj@kernel.org>
Cc:     Alon Zahavi <zahavi.alon@gmail.com>,
        almaz.alexandrovich@paragon-software.com, ntfs3@lists.linux.dev,
        linux-kernel@vger.kernel.org, Tal Lossos <tallossos@gmail.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH] ntfs3: Fix attr_punch_hole() null pointer derenference
Message-ID: <Y80+MZLA2sXyYf2J@kroah.com>
References: <20220815110712.36982-1-zahavi.alon@gmail.com>
 <20230117202136.116810-1-sj@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230117202136.116810-1-sj@kernel.org>
Precedence: bulk

On Tue, Jan 17, 2023 at 08:21:36PM +0000, SeongJae Park wrote:
> Hello,
> 
> On Mon, 15 Aug 2022 14:07:12 +0300 Alon Zahavi <zahavi.alon@gmail.com> wrote:
> 
> > From: Alon Zahavi <zahavi.alon@gmail.com>
> > 
> > The bug occours due to a misuse of `attr` variable instead of `attr_b`.
> > `attr` is being initialized as NULL, then being derenfernced
> > as `attr->res.data_size`.
> > 
> > This bug causes a crash of the ntfs3 driver itself,
> > If compiled directly to the kernel, it crashes the whole system.
> > 
> > Signed-off-by: Alon Zahavi <zahavi.alon@gmail.com>
> > Co-developed-by: Tal Lossos <tallossos@gmail.com>
> > Signed-off-by: Tal Lossos <tallossos@gmail.com>
> 
> This patch has now merged in mainline as
> 6d5c9e79b726cc473d40e9cb60976dbe8e669624.  stable@, could you please merge this
> in stable kernels?
> 
> Fixes: be71b5cba2e64 ("fs/ntfs3: Add attrib operations") # 5.14
> 

Now queued up, thanks.

greg k-h