Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF80C54EAA for ; Sun, 22 Jan 2023 14:02:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbjAVOC6 (ORCPT ); Sun, 22 Jan 2023 09:02:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbjAVOCz (ORCPT ); Sun, 22 Jan 2023 09:02:55 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 471461E9F9 for ; Sun, 22 Jan 2023 06:02:54 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id f25-20020a1c6a19000000b003da221fbf48so6773431wmc.1 for ; Sun, 22 Jan 2023 06:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=khU7ZPQc8roE7siv/yWI9eKECkTeVRE2Pp/ERSgrr1g=; b=Pr7fK8tvvSp5BqJp/rMDpdRQRijqjloQGCneGA5yIO1/JF2k4IGl5KIalhRxIFD00z szILRu0fOF3N3qVAM/PY4Z5ldE3imcyZFHFiRC+3In6DbTodie4w0l7K4NsCJ5F5a39w iGSann5xiBzktHxg7dSR3D1Lct3JUlXbUTyKSvdHgaoE9mGNwtkF9/OODmIrIv9JfiD0 z6ybG7G380Q6JO7wwwq4CxN+DBQAqqj/XGwKB0+A3iLAZ4zBCp5QdxTH5iYJW2VF27uN Hm/cma/lh1KYD4z24DGHsmtuh2wl3FsOiZPl66S3bl3gjVp6Ip+W9ISkdqMKPMRYxNt0 lFZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=khU7ZPQc8roE7siv/yWI9eKECkTeVRE2Pp/ERSgrr1g=; b=W2+BVtgP8L1MFUzwakdo4v4TiuRCdgQea80PQ6Aklr6dB8XtfK+8bGX9sRRobUTvok fRUUMfzgrAncIliu5dshouNFVbQMmA3Vv9kV11e18kkTn08eyVNHrH/wEBGtKN+X9Vpd hbF9irdwzpOJ8p6GlfSqGmZYL2E3LFuXYfk1OhZvx273dGfMhZwTa+0v6OS4Wtc2Hc8a XKFH//fz9KZ0b+tNhP9V2zKiOqOA38qXKUt4U9XNQs160WKJT8uSuns621Z9/Q9QMzeX mQjZo6PfIFPM4btBApkn3uBsr8V/TKB2BffHwcEvhuoGhU1Ts75RtZMlsLbTrDqyAdkj Xf0A== X-Gm-Message-State: AFqh2kplYuoqnONN+nzZYcp64avo79m/GVxJtdqjAUKbkOI0iG+2kzCo N99ljVDKZmSXBTQFeTB11QsRUw== X-Google-Smtp-Source: AMrXdXuCGIvpJAQmkTd6AvZBg2tWd/Puu4z2+FfvoGAjjOhEue65gT4+4Afc75Ph03oyTVJPm8FM8A== X-Received: by 2002:a05:600c:502c:b0:3db:30d:deac with SMTP id n44-20020a05600c502c00b003db030ddeacmr20710173wmr.1.1674396172865; Sun, 22 Jan 2023 06:02:52 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o24-20020a05600c511800b003d9de0c39fasm10675337wms.36.2023.01.22.06.02.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 06:02:52 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 15:02:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v3 2/5] dt-bindings: i2c: Add hpe,gxp-i2c Content-Language: en-US To: nick.hawkins@hpe.com, verdun@hpe.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230120190159.23459-1-nick.hawkins@hpe.com> <20230120190159.23459-3-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <20230120190159.23459-3-nick.hawkins@hpe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/01/2023 20:01, nick.hawkins@hpe.com wrote: > From: Nick Hawkins > > Document compatibility string to support I2C controller > in GXP. > > Signed-off-by: Nick Hawkins > > --- > > v3: > *Provide better description with use of Phandle > v2: > *Removed uneccessary size-cells and address-cells > *Removed phandle from hpe,sysreg-phandle > *Changed hpe,i2c-max-bus-freq to clock-frequency > --- > .../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > new file mode 100644 > index 000000000000..63bc69e92d0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/hpe,gxp-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP SoC I2C Controller > + > +maintainers: > + - Nick Hawkins > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: hpe,gxp-i2c > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + clock-frequency: > + default: 100000 > + > + hpe,sysreg: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to a global status and enable registers shared > + between each I2C controller instance. Each bit of the > + registers represents an individual I2C engine. But what is the purpose? What is it doing? Why I2C controller needs it? > + > +required: > + - compatible > + - reg > + - interrupts Keep the same order as in properties: Best regards, Krzysztof