Message-ID: <d5363f85-44e1-eee1-f7a5-61102637ef53@i2se.com>
Date:   Sun, 22 Jan 2023 15:21:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [RFC PATCH 0/4] Drop custom logging
To:     Umang Jain <umang.jain@ideasonboard.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Adrien Thierry <athierry@redhat.com>,
        Dan Carpenter <error27@gmail.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        linux-arm-kernel@lists.infradead.org,
        Kieran Bingham <kieran.bingham@ideasonboard.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-media@vger.kernel.org,
        Phil Elwell <phil@raspberrypi.com>
References: <20230118115810.21979-1-umang.jain@ideasonboard.com>
Content-Language: en-US
From:   Stefan Wahren <stefan.wahren@i2se.com>
In-Reply-To: <20230118115810.21979-1-umang.jain@ideasonboard.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:vwI63V1V3WM=;SxYw6lsSCKLJWlC8TWM51b41N/C
 46arB08+ShlPWqVQDGi50NtNc2kz/xfyUqQqfQPz8lPluLEic7k4FXonR+ncXvizb4jxNAlel
 F35rCJR5aKPbBpfRz6ULY+E8BAhpnrom+zjW1UUyv3TIB/5c15/XzLjVeSvKe0+bRfYNNd/W3
 4Tze5zdWg/2UWbe6kUaAHPDfK2KjbSB2+aGlo9VdSf8CTaBLHgKO/TxxnE2/qoMLOYiQGnC3s
 AoHEMlqwhAQt/6wWJUzS5PfLS+dbFQdBkXCrCkxiwQqERALPbkZ82Ml9i1jM72AzbxKlQk02x
 kkYYlHm0sKRIGgyfgzualUedCKKlWrAYAN+y14zruaz5855r1+8kBmLVsGvvJ/PZg5xk0vPZR
 LJPxxuRJhLxiDS0W4YTwrKMOLuwfIWCHSAfQoDf+8B8rPFB6giGrg58lH5KD5yu/62WiZexxI
 4uuReKS6Aru2ieVIxgyelr7/XO0vBGHpGdCz/045R3aIY+QV4Lvp6yFPEBusOJgK6rAyDLN1Z
 7E2DjBCZeZtb7ckvYrrhIXxozIIexL3Gdk8htOc6RMdl9fGeOjlqNU4wMwFVKeJ98uahcgn58
 gfzn6mcmiAfoll8vCBywItbmbwQ215yedZbbNw5F1JCs+m9hHtTTs2GoF3hFEFamHI/qxMpWk
 stTFPHJErEDGFPyVnNBRW0+H11cofJ6egF1cwgnqyg==
Precedence: bulk

Hi Umang,

Am 18.01.23 um 12:58 schrieb Umang Jain:
> Drop custom logging from the vchiq interface.
> Mostly of them are replaced with dev_dbg and friends
> and/or pr_info and friends.
>
> The debugfs log levels (in 4/4) are mapped to kernel
> logs levels (coming from include/linux/kern_levels.h)
> Would like some thoughts on it as I am not sure (hence
> marking this is RFC)
>
>  From drivers/staging/vc04_services/interface/TODO:
>
> """
> * Cleanup logging mechanism
>
> The driver should probably be using the standard kernel logging mechanisms
> such as dev_info, dev_dbg, and friends.
> """

at first i want to thank you for the work on vchiq so far.

There is something which is not directly related to this series, but it 
is also about debugging. The driver has a buffer which is accessed by 
it's own DEBUG_* macros. The content of this debug buffer can be dumped 
via the /dev/vchiq which is also used by ioctl. I would appreciate to 
move this dump feature into a new debugfs entry.

Best regards