MIME-Version: 1.0
References: <20220718105553.6529-1-gaoxin@cdjrlc.com>
In-Reply-To: <20220718105553.6529-1-gaoxin@cdjrlc.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Sun, 22 Jan 2023 17:33:19 +0100
Message-ID: <CAMuHMdWtD29w1Utw0VvAC1SrE47x-o+bOcp6=fOGsfWLQHBsUQ@mail.gmail.com>
Subject: Re: [PATCH] m68k:do not initialise statics to 0.
To:     gaoxin@cdjrlc.com
Cc:     linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Xin,

On Mon, Jul 18, 2022 at 12:56 PM Xin Gao <gaoxin@cdjrlc.com> wrote:
> Delete static variables initialized to 0.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>

Thanks for your patch!

> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -201,8 +201,8 @@ static int ccleirq=60;    /* ISA dev IRQs*/
>  #define DEBUG_Q40INT
>  /*#define IP_USE_DISABLE *//* would be nice, but crashes ???? */
>
> -static int mext_disabled=0;  /* ext irq disabled by master chip? */
> -static int aliased_irq=0;  /* how many times inside handler ?*/
> +static int mext_disabled;  /* ext irq disabled by master chip? */
> +static int aliased_irq;  /* how many times inside handler ?*/
>
>
>  /* got interrupt, dispatch to ISA or keyboard/timer IRQs */

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v6.3 branch.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds