Message-ID: <dc32dfd0-7ad9-d295-cc35-d6bf2490f8a8@asahilina.net>
Date:   Mon, 23 Jan 2023 02:07:12 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] soc: apple: rtkit: Add register dump decoding to crashlog
Content-Language: en-US
To:     Sven Peter <sven@svenpeter.dev>, Hector Martin <marcan@marcan.st>
Cc:     Alyssa Rosenzweig <alyssa@rosenzweig.io>, asahi@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230121073741.3807-1-lina@asahilina.net>
 <938ee8b4-3745-43a7-b813-801df22f2888@app.fastmail.com>
From:   Asahi Lina <lina@asahilina.net>
In-Reply-To: <938ee8b4-3745-43a7-b813-801df22f2888@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22/01/2023 19.19, Sven Peter wrote:
> On Sat, Jan 21, 2023, at 08:37, Asahi Lina wrote:
>> When the coprocessor crashes, it's useful to get a proper register dump
>> so we can find out what the firmware was doing. Add a decoder for this.
>>
>> Originally this had ESR decoding by reusing the ARM64 arch header for
>> this, but that introduces some module linking and cross-arch compilation
>> issues, so let's leave that out for now.
>>
>> Signed-off-by: Asahi Lina <lina@asahilina.net>
>> ---
> 
> Reviewed-by: Sven Peter <sven@svenpeter.dev>
> 
> thanks,
> 
> Sven

Thanks for the review! The kernel test robot complained about builds on
non-ARM64, so I'll fix that up and send a v2 ^^

~~ Lina