Subject: Re: [PATCH] paride: Mark PARIDE as deprecated, point to PATA_PARPORT
To:     Ondrej Zary <linux@zary.sk>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>
CC:     Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Tim Waugh <tim@cyberelk.net>, <linux-block@vger.kernel.org>,
        <linux-parport@lists.infradead.org>, <linux-ide@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230122075710.GA4046@lst.de>
 <20230122181415.21031-1-linux@zary.sk>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <89c5f007-3be3-f1d1-f6f3-c5c1923a9f2a@omp.ru>
Date:   Sun, 22 Jan 2023 22:11:38 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20230122181415.21031-1-linux@zary.sk>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled
X-KSE-Antivirus-Interceptor-Info: scan successful
X-KSE-Antivirus-Info: Clean, bases: 1/22/2023 3:31:00 PM
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello!

On 1/22/23 9:14 PM, Ondrej Zary wrote:

> Add Kconfig and runtime deprecation warnings to PARIDE, pointing users
> to PATA_PARPORT.
> 
> Signed-off-by: Ondrej Zary <linux@zary.sk>
[...]
> diff --git a/drivers/block/paride/paride.c b/drivers/block/paride/paride.c
> index 0e287993b778..010daf605728 100644
> --- a/drivers/block/paride/paride.c
> +++ b/drivers/block/paride/paride.c
> @@ -452,6 +452,8 @@ void *pi_register_driver(char *name)
>  	struct parport_driver *parp_drv;
>  	int ret;
>  
> +	printk(KERN_WARNING "PARIDE is deprecated. Use PATA_PARPORT instead.\n");

   Why not pr_warn()?

[...]

MBR, Sergey