Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 929CAC25B4E for ; Sun, 22 Jan 2023 20:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231268AbjAVUK7 (ORCPT ); Sun, 22 Jan 2023 15:10:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbjAVUKz (ORCPT ); Sun, 22 Jan 2023 15:10:55 -0500 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7284B12F37; Sun, 22 Jan 2023 12:10:53 -0800 (PST) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id A07C27A033B; Sun, 22 Jan 2023 21:10:52 +0100 (CET) From: Ondrej Zary To: Damien Le Moal Cc: Christoph Hellwig , Sergey Shtylyov , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] paride: Mark PARIDE as deprecated, point to PATA_PARPORT Date: Sun, 22 Jan 2023 21:10:46 +0100 Message-Id: <20230122201046.1924-1-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <89c5f007-3be3-f1d1-f6f3-c5c1923a9f2a@omp.ru> References: <89c5f007-3be3-f1d1-f6f3-c5c1923a9f2a@omp.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add Kconfig and runtime deprecation warnings to PARIDE, pointing users to PATA_PARPORT. Signed-off-by: Ondrej Zary --- drivers/block/Kconfig | 4 +++- drivers/block/paride/paride.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index a2184b428493..3a2065c6a4d7 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig @@ -104,7 +104,7 @@ config GDROM You can also build this as a module which will be called gdrom. config PARIDE - tristate "Parallel port IDE device support" + tristate "Parallel port IDE device support (DEPRECATED)" depends on PARPORT_PC help There are many external CD-ROM and disk devices that connect through @@ -130,6 +130,8 @@ config PARIDE "MicroSolutions backpack protocol", "DataStor Commuter protocol" etc.). + This driver is deprecated, replaced by libata-based PATA_PARPORT. + source "drivers/block/paride/Kconfig" source "drivers/block/mtip32xx/Kconfig" diff --git a/drivers/block/paride/paride.c b/drivers/block/paride/paride.c index 0e287993b778..a4a49da9d0d2 100644 --- a/drivers/block/paride/paride.c +++ b/drivers/block/paride/paride.c @@ -452,6 +452,8 @@ void *pi_register_driver(char *name) struct parport_driver *parp_drv; int ret; + pr_warn("PARIDE is deprecated. Use PATA_PARPORT instead.\n"); + parp_drv = kzalloc(sizeof(*parp_drv), GFP_KERNEL); if (!parp_drv) return NULL; -- Ondrej Zary