Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185B7C54EAA for ; Mon, 23 Jan 2023 00:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230082AbjAWA7q (ORCPT ); Sun, 22 Jan 2023 19:59:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjAWA7p (ORCPT ); Sun, 22 Jan 2023 19:59:45 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDB5212863; Sun, 22 Jan 2023 16:59:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A71260D30; Mon, 23 Jan 2023 00:59:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA8F0C433D2; Mon, 23 Jan 2023 00:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674435583; bh=aC/7hAS/iZ638iCeHTXW7ZxH+T5LjHCoRqraTQYaT5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vChyDaPp0pQDcWsRVA8gQLuAMqBZHbaVd4R7zzukpkj5qiXLmMB/g7lE9VLrgR3Gz MjT7HHlzBS69JQIL7PNEX45jgNaSvNetFdHaOL+qw5xTtiz65YNqEfLQm0FbdG1LW2 ic71fTR2o4CAsXbIqEi/EAOc21xByj86efMts4y1cS1fVCqELizyQ16aFHA9n0wIES USAOBzH+fFX10X7ZgEZ5kXiq6qboJBlZzoXDerc+BQSvSIAsuTvU53q099GqkcQxf0 Jl9GpyQAroKDdT6TVkC8dX1BfJniquDxiTpJ8MgfGJd5osws0WjKuJpy9AfzN8hH7b 73myUSQFwiKHQ== Date: Sun, 22 Jan 2023 19:59:42 -0500 From: Sasha Levin To: Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bartosz Golaszewski , linux-spi@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.10 11/17] spi: spidev: fix a race condition when accessing spidev->spi Message-ID: References: <20230116140448.116034-1-sashal@kernel.org> <20230116140448.116034-11-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2023 at 02:40:05PM +0000, Mark Brown wrote: >On Mon, Jan 16, 2023 at 09:04:42AM -0500, Sasha Levin wrote: >> From: Bartosz Golaszewski >> >> [ Upstream commit a720416d94634068951773cb9e9d6f1b73769e5b ] >> >> There's a spinlock in place that is taken in file_operations callbacks >> whenever we check if spidev->spi is still alive (not null). It's also >> taken when spidev->spi is set to NULL in remove(). > >There are ongoing discussions of race conditions with this commit. Okay, I've dropped it. Thanks! -- Thanks, Sasha