MIME-Version: 1.0
References: <20230120190159.23459-1-nick.hawkins@hpe.com> <20230120190159.23459-2-nick.hawkins@hpe.com>
In-Reply-To: <20230120190159.23459-2-nick.hawkins@hpe.com>
From:   Joel Stanley <joel@jms.id.au>
Date:   Mon, 23 Jan 2023 05:11:45 +0000
Message-ID: <CACPK8Xe46F4Rk1jkLzXdzHE8t_HePe83teTrwUoV4wMvOn4_CQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/5] i2c: hpe: Add GXP SoC I2C Controller
To:     nick.hawkins@hpe.com
Cc:     verdun@hpe.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
        linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 20 Jan 2023 at 19:04, <nick.hawkins@hpe.com> wrote:
>
> From: Nick Hawkins <nick.hawkins@hpe.com>

> +static int gxp_i2c_remove(struct platform_device *pdev)
> +{
> +       struct gxp_i2c_drvdata *drvdata = platform_get_drvdata(pdev);
> +
> +       disable_irq(drvdata->irq);

The i2c core calls disable_irq for us (see i2c_device_shutdown) so you
don't need that here.

In my review I wondered if you needed to do something like this:

+               regmap_update_bits(i2cg_map, GXP_I2CINTEN, 0x00000FFF, 0);

> +       i2c_del_adapter(&drvdata->adapter);
> +
> +       return 0;
> +}
> +