Message-ID: <302afd51-07c2-04b3-98a0-ee9d8fc5397c@meta.com>
Date:   Sun, 22 Jan 2023 21:22:28 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH] tools: bpf: Disable stack protector
Content-Language: en-US
To:     Peter Foley <pefoley2@pefoley.com>
Cc:     Eduard Zingerman <eddyz87@gmail.com>,
        Quentin Monnet <quentin@isovalent.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
References: <20230114-bpf-v1-1-f836695a8b62@pefoley.com>
 <701abf4bbf5b7957a24d2f164c643e1d9f586fad.camel@gmail.com>
 <4dc6a571-8564-b38c-31df-0d9741dfc592@meta.com>
 <CAOFdcFOh_rNt3pfkNHPPeK=Kojro==Kpgmmu-VnLuaMYfFoiwg@mail.gmail.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <CAOFdcFOh_rNt3pfkNHPPeK=Kojro==Kpgmmu-VnLuaMYfFoiwg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFhkMk5vYjNnZHVsM2pRUnoySkh1b1JBdytvLzQ5NStlTkFhVTAxSlJZWnh3?=
 =?utf-8?B?N0d0bDBwb3crNmhJSTRNbGlVRlFLNHVzZUd3WGp1dHZUbUU1NDRDMWVDYmtH?=
 =?utf-8?B?Vk80NjVsVm1ZN2xyc1dXem5TVTI4VDdVcDB4aU1KOWxUbGxNSmVQUGNjaDNH?=
 =?utf-8?B?dWRFWlhIelZteXNXS2orMTlDVzE0M1VGQS9PNTMrNGZoMnlraGVyWmc1cUxB?=
 =?utf-8?B?bnhYK082K2tuWG5CLzdwRngwcVBCdnlJcnhGMi9uNktoTEw5ZDdLN3FkbG1k?=
 =?utf-8?B?Yzl2S0crODl1aFpFdndGRkJBbExFdEhEdldFRVJ2QkpBTTA0T05Yc2lSSmZp?=
 =?utf-8?B?blJIblI3a1VHeEJwclYyVjFVK2x0dE8wU1R5aVI5ZDhpbElqMEhWYnZ5V0pH?=
 =?utf-8?B?Y0J3M1didWRoTmR0eWhDWWJqNWFpVTNnek1YTHhWVy95dHU1bU0xdFRCTTQ2?=
 =?utf-8?B?OFBTaVZtTUllNXZpQ29YVCtMM0lFUlJyMVo4UnpUckVzUFIyVm9jcGs0S2E4?=
 =?utf-8?B?RXVTSk00Z1YwTXhjdlhiT1ZzMmtpZU9YekNDS3dTc3NRbkZIdEZFMUY0dUtx?=
 =?utf-8?B?c1dmU3VEcE11allyVDVMNWh6T0diK3dNbkRzc3pPQVVFVnk1dUdHYlYrd2Ri?=
 =?utf-8?B?dTBzUUkySGpnS0YvTC84WjJUVFJ6L1BPL1hUT2Rsb2ppd3NuUHh1eXJYOXBi?=
 =?utf-8?B?L2lJa0NSLzVKbFBvNUU0Z09HbHFGT2xiTS9KSDhLaUMxb0RLckdkcU9nTWhZ?=
 =?utf-8?B?bUN5L3hBY1BlejlLZEZPdUNtS3VkV21wbXI0OWY0TGYvRk0xM0l2NGdSZG9Y?=
 =?utf-8?B?ZmZVOFZ6ZUhKVGREbnczZlpVZ0Y4bVRoS3dBWmVLUVc4b3d2UXJpakJaUGg3?=
 =?utf-8?B?bmozdUdTRDdiRUNOc0RRMWZvcWV3SEVlS1RzcWcyYkcxeDl6SmFIWkpJSXU1?=
 =?utf-8?B?S0FRRHRYVFd5eGJPaEMvQ0ZCdUYzZlZGY2xmZlJUcXZvQzVzMDdKK0N5dGU5?=
 =?utf-8?B?YzdwdnJQMGk0aWZUL3JjUk0wdUxBRVJXdlBieENuOUo0YTlVN3BzemxOMDhO?=
 =?utf-8?B?Z012MnhaZkFpQmFaUnFxQ1dQcEpGeVVteGVHdGlOSXl5czFtMDBLTFN3RzhN?=
 =?utf-8?B?OExRZnZySGxQQVppd2VaMHBMMmZHODczUCtTKzJaT1hoWFpHVzczNWdRWFd6?=
 =?utf-8?B?Ulp2T0t2SWJOUUE2RkUxYU5LTVJ1NWFEeHg0cnJIdTNOWFdPVERDNkx0ZlRC?=
 =?utf-8?B?TXA5SnVpb1J2YjdocFRDMEpHUElsZkFRRW9kd01RQUJhaTByVnIrMCtsMG1Y?=
 =?utf-8?B?emJYeFNvbzhqbkE2ZVNZMXYvWmpuMkViS0R3OFBpTWg3QkJwVHhoaHdmS1B0?=
 =?utf-8?B?azNUYU93ak1LNlpFYTNCdEc0T21FaHh2REJ5b2YzV1JMdlEwL25oM0c1Rk1S?=
 =?utf-8?B?bXpCaUUrQXg1SE9CRlMvNDZjYU9NRU5jUjZ4VHdqQ3AvaHFiTHZXRk1qaStz?=
 =?utf-8?B?Y1l5Sk5sbC80U25LMURxUkw5UEt2WWNhNEh3MFNsNkZGZlRieHFIOWhOeHJJ?=
 =?utf-8?B?YVB2N0tWSWgvR2c5QUpzdVZGS1VvTGJTZEd1T1YwQ3lkc2Y3SVFCY1YwL0Rx?=
 =?utf-8?B?RnYxOWp4cUxLV2ZuL2RCTWNONi9mcDJmNzluMlduZzBVSG1iVVVrNjExc29n?=
 =?utf-8?B?MVhadVlOU3J1Ry9lMlNVQll3SFdNZE0weDBDbnZZSTNKUzVhVDdVZnVKajdu?=
 =?utf-8?B?WWF3ZTdSaVhVT09FQ29sSW05aHpxU1ovdmxCZHhHMFBxK2ZkR3dpcmNnam5h?=
 =?utf-8?B?OWdDODA2ZVN0eWl4SkNXbFJuSzdxbHFqNHVVelVIbXROVDBTcUkvN1gxeGRk?=
 =?utf-8?B?bjdzVmtsc05YMFFRVVNYZzBZK2t5UEdWaDdlRzhsaWY5U01qM011SzFGME1B?=
 =?utf-8?B?Y01IbEtyN1NBeERwSlpGbnlQR29oYnV1STlqV0RlS3ROOEsrQXBud0xCSUx5?=
 =?utf-8?B?MUhtU3R6Z2N2dzh0K0pvOVh0TTVTZDVIZEVtaE9zOEQ4TFJWNWRMWmNUSCty?=
 =?utf-8?B?RGxvL3dUSThSSmwvcXFWbFpSbkpWMDhNSGl1WkZyZEJGanNUYktCdFJwN3FC?=
 =?utf-8?B?cHJtMVl5ZWJ5REdCV1NkUHJZcm5WQzNRbVArdGhtcno2OEg4dXJjRFJjNFE2?=
 =?utf-8?B?MVE9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1726a2aa-1bad-4cd4-9fc2-08dafd01d353
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 05:22:31.0332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SdS2eNoMogO7NHvNUo3DfpMxzw4QXtGBLAopf4GK7syl7DwlZxC/pG9tf0gGEjjz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB4449
X-Proofpoint-GUID: _y5cf-hvKDSw5Zf_KjtBmRO7uWN_SxNv
X-Proofpoint-ORIG-GUID: _y5cf-hvKDSw5Zf_KjtBmRO7uWN_SxNv
Content-Transfer-Encoding: 7bit
X-Proofpoint-UnRewURL: 1 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-23_02,2023-01-20_01,2022-06-22_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/22/23 8:28 PM, Peter Foley wrote:
> On Wed, Jan 18, 2023 at 11:34 PM Yonghong Song <yhs@meta.com> wrote:
>> On 1/18/23 11:28 AM, Eduard Zingerman wrote:
>>>
>>> While working on clang patch to disable stack protector
>>> for BPF target I've noticed that there is an option to
>>> disable default configuration file altogether [1]:
>>>
>>>     --no-default-config
>>>
>>> Should we consider it instead of -fno-stack-protector
>>> to shield ourselves from any potential distro-specific
>>> changes?
>>
>> Peter, could you help check whether adding --no-default-config works
>> in your environment or not?
>>
>>>
>>> [1] https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-no-default-config
> 
> I guess I could, but I'm not convinced that's the right thing to do.
> Ideally problems with distro-specific configs would cause loud
> failures (like this one) and result in fixes like the changes being
> made to upstream clang/gcc.
> Simply unconditionally disabling distro configs seems to be the wrong
> way to approach this and makes it less likely that future problems
> will be reported in the first place.

Thanks for confirming. Eduard has implemented a proper fix in clang
(https://reviews.llvm.org/D142046) which will warn if -fstack-protector
is enabled. In gentoo case, since -fno-stack-protector is appended to
compilation flags, no warning will be issued, so we are all good here.