Message-ID: <7c9c11e5-c5f2-d36f-6204-ebc76646ee35@nvidia.com>
Date:   Mon, 23 Jan 2023 12:52:18 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RESEND v4 2/5] PCI: tegra194: Move dw_pcie_ep_linkup() to
 threaded IRQ handler
Content-Language: en-US
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        kishon@kernel.org, lpieralisi@kernel.org, bhelgaas@google.com
Cc:     linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        kw@linux.com, robh@kernel.org, vigneshr@ti.com
References: <20230111114059.6553-1-manivannan.sadhasivam@linaro.org>
 <20230111114059.6553-3-manivannan.sadhasivam@linaro.org>
From:   Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <20230111114059.6553-3-manivannan.sadhasivam@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVVpaDBZeVJzQk9KQVJnazAzc1NFQXV0QkZlKzRuMndHOTJrZWo5cHE2SzJ0?=
 =?utf-8?B?WlVFY1hiSjZBandJeFlyMWhOaDdBbHRMZXNuWkl5NUJ1UXZkNmtuS29VZGZn?=
 =?utf-8?B?eVcySVpuRkY0OWc5em1VRmJrUVdkSGNSbFFQUU5ueVZxdTQ4WVMwUG1uZldx?=
 =?utf-8?B?TUlOeC94QmM4OTFWZmM1Ky9CcXk1M01GTTBXREFJMGE3eWhNNmNobkFvOTdB?=
 =?utf-8?B?ZGV3VUFEejVHY3d1YkVRZWg1OWRYbmFKbjhMUWNxL1A0RXpZVW9jV1luVUJK?=
 =?utf-8?B?c0Y1U2todER4QytheEVUNUR3R2EvUHFYdXRuQlV6SEUxMzVRQkpOMWJjVldU?=
 =?utf-8?B?VnhhYU9vN3Mrc2tscUN1Yi8ySklLNzlvbEhac0g2am9vcFR1SzhwNloxelhU?=
 =?utf-8?B?bWRBdXVnTDA3SXRsMFh2ZVdwSjFRNFlTSmdlR0h1ZEtVSVhFNDRjOStyb1J6?=
 =?utf-8?B?ZVNMRWxKbm40cXBUOU93Q2RGNGxKeFlYQmNQVEd3VjBqZ0czckpBbGNZNHEv?=
 =?utf-8?B?Qkk3cTFTVjZocHI3aTQzelBpdTVSWjRiT2JGeGRpQTU0eXdoc25oczlaTVBK?=
 =?utf-8?B?aGxka2l3VVF2dkxPYkx6bE1XNEhNbGxPeThuSVE0ekRvOElIaHQyS2dJbjg1?=
 =?utf-8?B?ZTNEclFybkNTd1dzTGhDa2VmLzVmbTFPemJUaGY3ZzdwS0NMZFpzNUxmMmht?=
 =?utf-8?B?S3ZQa1NMZVZSRVNZVW11MlBjaHFrdWF6Y2lpMnFmVWpSNE1keXlseHE5ejVO?=
 =?utf-8?B?czM0VHF1dHBrWTBxQkNaUFhvbjhzaXRzU1lEZ1RCa0JSZmRkdGcvYU55djdW?=
 =?utf-8?B?WkNRUmJmQy9RaFNoVlVseXRiOEhRSE8rK0FYMmZONG5vY2VhQ1RwVzUvUGZE?=
 =?utf-8?B?TVlDRngwbjQvcWRxNFdYOGVXTmxPYnZoV2hGN3A2WElZUmd4ald4NnE3a09P?=
 =?utf-8?B?WXM1RHNtV3RtK3ZNQlI0VjFWRFhTeVVRUkpyR0o3NnZoVFAvSXhuZEpSMUxj?=
 =?utf-8?B?ZEVtK205Z0IrWHdNUWVZWnBNemFpUEthZ3JXeHUxZXZtZ1NBWWh2Y1BncnYr?=
 =?utf-8?B?NjBvbDZLeDZRVjVLSHJPT1dRWWlWTEl0cS9samY3M1lEQzZxWHBGOHNnbTJG?=
 =?utf-8?B?eklNZzZUVERCZjJTUkhoa3NtcVA2VENraEFTUTJXUWRUTjI3NEVNWTd6R283?=
 =?utf-8?B?a2lRYTl1VnhhbWFaS0FJdVRoeXNqanBvVWM0alluKzJ0YlNhZWxablQweEI4?=
 =?utf-8?B?WWIvRm5wMmlFdnIvclhtUnJkMWFPejY0TlhBTkV2WkxlTSt2STJDcm4vcWNs?=
 =?utf-8?B?VSttTmdYZmp4L3p3VFY4TkV1NkYrQmhQZGk2dy84VUNOa3hLdjNxSmhkL0pP?=
 =?utf-8?B?ZjNONjlrSnI3NzhKQUdwSW4xVFNFQWpZRWpzRXNnREdQUDBGaTFPbU81ZFhJ?=
 =?utf-8?B?eWlNMWcxMFVLYWk5Rk02b3pKUzRuOWcvZ0RiNzNNbStwM3M2RWJieVhVTGVI?=
 =?utf-8?B?LytnNVA5NDlQOER5ZkdBekRJTGkvdURrYXR1R2dPRisyT3hTd2ZLcmlpbHlo?=
 =?utf-8?B?bktIaEo4TmU1YzNxemM3VEJvR3lhWkw0UXo1aHk2cUsrVk9hSzFYS2REUS9F?=
 =?utf-8?B?OTNHOG5NN29senBsZi9URlpiSVNXaUtaQjZIUy9Yak90R2d0bWdOTG9PMEtE?=
 =?utf-8?B?MzBWZUFldXRjUUQwZUhOdHBtQldoTTVQVlAvN1BwbGRWZzFoYnFvaTVkOWpM?=
 =?utf-8?B?dVBydi9IMzJ2MkZQNUJLWkdlZE1hbWRvaHY4enNaUGxtUVlnMktJZTJwZXhE?=
 =?utf-8?B?aSswRmk3RGlaTXNBN3BqeDhWd1J3TUtOUzRQRWpLTXlKWWhWQmIxYm4wb2R5?=
 =?utf-8?B?WGF3NXpOYzEvZy8vbWE1Yk9vekZiWGp2TXZCZnFjbEtGaFpMVDZYelUxTjJL?=
 =?utf-8?B?UFl5d1piMGVLMmZhWGtMSlcwZUMvc1U0anRYVmdwV3NUY01WeGU5ZXlYVHAw?=
 =?utf-8?B?bTA1VkVMUTFTZGdReVh5SEw2dDU4SjdqdDczWVRweXQrbm1LSmVGdmRybmNl?=
 =?utf-8?B?eEtpc25reHJrT29yOEtxNk1rOE9QUWFxcG96V2FFRlo4bE9DTW8vRmtXTmZm?=
 =?utf-8?Q?FRWNmGsMKEksNcOn+mwppXcpe?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c14da10-2c9e-458b-4d93-08dafd1296e3
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB2900.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 07:22:31.3595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B/8xWWl20JfajyJ8F6THMBfZ483jI07qsdZBwhEoyLOjut7lJgswdSKC1Owa9qQtR4wmhFzhv9U1ymGzS54i2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5077
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for pushing this change.

Reviewed-by: Vidya Sagar <vidyas@nvidia.com>

On 1/11/2023 5:10 PM, Manivannan Sadhasivam wrote:
> External email: Use caution opening links or attachments
> 
> 
> dw_pcie_ep_linkup() may take more time to execute depending on the EPF
> driver implementation. Calling this API in the hard IRQ handler is not
> encouraged since the hard IRQ handlers are supposed to complete quickly.
> 
> So move the dw_pcie_ep_linkup() call to threaded IRQ handler.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>   drivers/pci/controller/dwc/pcie-tegra194.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 02d78a12b6e7..09825b4a075e 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -286,6 +286,7 @@ struct tegra_pcie_dw {
>          struct gpio_desc *pex_refclk_sel_gpiod;
>          unsigned int pex_rst_irq;
>          int ep_state;
> +       long link_status;
>   };
> 
>   static inline struct tegra_pcie_dw *to_tegra_pcie(struct dw_pcie *pci)
> @@ -449,9 +450,13 @@ static void pex_ep_event_hot_rst_done(struct tegra_pcie_dw *pcie)
>   static irqreturn_t tegra_pcie_ep_irq_thread(int irq, void *arg)
>   {
>          struct tegra_pcie_dw *pcie = arg;
> +       struct dw_pcie_ep *ep = &pcie->pci.ep;
>          struct dw_pcie *pci = &pcie->pci;
>          u32 val, speed;
> 
> +       if (test_and_clear_bit(0, &pcie->link_status))
> +               dw_pcie_ep_linkup(ep);
> +
>          speed = dw_pcie_readw_dbi(pci, pcie->pcie_cap_base + PCI_EXP_LNKSTA) &
>                  PCI_EXP_LNKSTA_CLS;
>          clk_set_rate(pcie->core_clk, pcie_gen_freq[speed - 1]);
> @@ -498,7 +503,6 @@ static irqreturn_t tegra_pcie_ep_irq_thread(int irq, void *arg)
>   static irqreturn_t tegra_pcie_ep_hard_irq(int irq, void *arg)
>   {
>          struct tegra_pcie_dw *pcie = arg;
> -       struct dw_pcie_ep *ep = &pcie->pci.ep;
>          int spurious = 1;
>          u32 status_l0, status_l1, link_status;
> 
> @@ -514,7 +518,8 @@ static irqreturn_t tegra_pcie_ep_hard_irq(int irq, void *arg)
>                          link_status = appl_readl(pcie, APPL_LINK_STATUS);
>                          if (link_status & APPL_LINK_STATUS_RDLH_LINK_UP) {
>                                  dev_dbg(pcie->dev, "Link is up with Host\n");
> -                               dw_pcie_ep_linkup(ep);
> +                               set_bit(0, &pcie->link_status);
> +                               return IRQ_WAKE_THREAD;
>                          }
>                  }
> 
> --
> 2.25.1
>