Message-ID: <fb1cab9f-a373-38e6-92e6-456332010653@gnuweeb.org>
Date:   Mon, 23 Jan 2023 16:02:22 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Content-Language: en-US
To:     "H. Peter Anvin" <hpa@zytor.com>
Cc:     Dave Hansen <dave.hansen@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Li, Xin3" <xin3.li@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <SA1PR11MB6734FA9139B9C9F6CC2ED123A8C59@SA1PR11MB6734.namprd11.prod.outlook.com>
 <5d4ad3e3-034f-c7da-d141-9c001c2343af@intel.com>
 <18B5DB6D-AEBD-4A67-A7B3-CE64940819B7@zytor.com>
 <SA1PR11MB673498933098295BFC7C2900A8CB9@SA1PR11MB6734.namprd11.prod.outlook.com>
 <b6e36a5c-6f5e-eda6-54ad-a0c20eb00402@intel.com>
 <25b96960-a07e-a952-5c23-786b55054126@zytor.com>
From:   Ammar Faizi <ammarfaizi2@gnuweeb.org>
Subject: Re: the x86 sysret_rip test fails on the Intel FRED architecture
In-Reply-To: <25b96960-a07e-a952-5c23-786b55054126@zytor.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/23/23 6:45 AM, H. Peter Anvin wrote:
> static enum regs_ok check_regs_syscall(int syscall,
>      unsigned long arg1, unsigned long arg2)
> {
> 
>      register unsigned long r11 asm("%r11");
>      unsigned long rcx, rbx, tmp;

tmp is unused.

>      r11 = r11_sentinel;
>      rcx = rcx_sentinel;
> 
>      asm volatile("push %3; popf; "
>               "lea 1f(%%rip),%2; "
>               "syscall; "
>               "1:"
>               : "+r" (r11), "+c" (rcx), "=b" (rbx)
>               : "g" (rflags_sentinel),
>                 "a" (syscall), "D" (arg1), "S" (arg2));

BTW, I just realized this "push" is unsafe for userspace code if the
compiler decides to inline this inside a leaf function that uses the
redzone.

Reason: Because this "push;" clobbers redzone.

It doesn't always happen, but when that happens it can be confusing to
debug.

A simple workaround is: just compile it with "-mno-red-zone" flag.

Alternative, without using that flag, maybe preserve the value like:

     movq    -8(%rsp), %r12
     pushq   %[rflags_sentinel]
     popf
     movq    %r12, -8(%rsp)
     syscall

with "r12" and "memory" added to the clobber list.

What do you think?

-- 
Ammar Faizi