Message-ID: <bfdea5aa-13d5-338f-bb5d-c05df45f7859@nokia.com>
Date:   Mon, 23 Jan 2023 10:08:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH RESENDv2] arm: topology: Consider clock-frequency property
 from parent /cpus node
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221216124157.13270-1-stefan.wiehler@nokia.com>
 <Y5xqVmO9ZHWYW3Du@shell.armlinux.org.uk>
Content-Language: en-US
From:   Stefan Wiehler <stefan.wiehler@nokia.com>
Organization: Nokia
In-Reply-To: <Y5xqVmO9ZHWYW3Du@shell.armlinux.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUhCeFNuNm8zNERmUEM2K05obmZkZTBra3ZQTlRzQzlXRDhXYUU5R2dHdXJt?=
 =?utf-8?B?UVdGd3l3cTZRNzBCWEhLUlVGZjN6b1V2TStYQ1I2Q0hqNkZLbXFpa2JRdlpo?=
 =?utf-8?B?VUhQYTUyZW1qaVBacFMrTHV5ZDRLaDFTeW0zZ1hTUC8wbUtmcitrS3Y1NU9K?=
 =?utf-8?B?U3dyMXg3cEtwRndRYkdMdzJ5KzlOVzRYOFU5SFpwWUMyRzN0dk1vYXVvK3BW?=
 =?utf-8?B?aTZ2NmRzcEI3SE1PL00rWWh1NmpqRXNoa2wwQ3NkQ0RlUmxwRENpYWdGSlpV?=
 =?utf-8?B?cHJYKzJOeDZjMS9JTE1qS0IvU3dFU0Q4MDlUczNIYmFvZTFjdHZLMDZuRGNx?=
 =?utf-8?B?TCtpeVVMc2VvdkdFYXV1LzhrZEFoMEdURWZwMHVkZm95UnVaa0szSmF1Qzk0?=
 =?utf-8?B?UnV5cHBDa2RCOHRicFdDMGM0YzMyT0RtRzFidmhnR2txclZkNkNkT3YyRE14?=
 =?utf-8?B?eldwRzI3emVHNEtpaWtkMzAyKzZVZldYMDBGNFQ2Q2lMZTYyRHFmMnR6NkI5?=
 =?utf-8?B?SmNod3NkSHhzY25GbTd5QWtEbUY0Zm1NeDN0NG0xTEE1eWFJWVBxcjIrV0Za?=
 =?utf-8?B?dVNNc1RQcE4xVm9wSFpjUVQ1NCsxVTl4SnNOclIyLzIvODNsM1hGeWlXNWY0?=
 =?utf-8?B?NzkwN0p2VmQvdUc1Z3Iya3FIYlpJTUE3Kytoek5leG5HOGVwdEpXWTlmZnlM?=
 =?utf-8?B?SGZjZnd3eHFmMGw0aE1lNk1yREpkcHEvK3NkeTdOQWlyb2lmNXJicjVhdUxH?=
 =?utf-8?B?QlFidm54amJUdm1oelVnbjVNcWphUldOV1UreE9qTjJzN1hXTHZCTC9NNGFr?=
 =?utf-8?B?TGROOGlEYVpVdHN3ay9NMHI4dm54Zjd6dnFML1VzdldLRnhkbkVFVWRsdzRZ?=
 =?utf-8?B?b0VtTGxtdHlvVTFNOEtBTzZxbEVEYitSUmRwVmVyR3pvRk95djVlOGJGN0U2?=
 =?utf-8?B?WXorZjJjTVhISWZxTUZtZmtENFBEUTNvM1hMTXk3NWJPemxrRS9tQUVzclFL?=
 =?utf-8?B?bmhvMkVvcW1qVFFpODFjUm5KTHE5WXN1RzRkTVhQR0dPYkg3NHk5bzVPeHgr?=
 =?utf-8?B?SXE3ZHA5dmhLS2hPVktIdmJXOGtWcERVcWVsS2ovSWo4N2VuUUljU3E0OGtT?=
 =?utf-8?B?aHg5VHNxU2s4RmxGK3AvQkFQL0RWanExS3JPaVovbXR5QjNzNDZSZ2c2SWV1?=
 =?utf-8?B?ZkxwcThndEpIb3JrekR6TEJVdlhnZnl3VmlLRTVvWUhjekJGdFNWaWg2SHF3?=
 =?utf-8?B?ZWU0REh1NEhIMWhxTmk0UGk0NEFNaFF0VjcydGlqenBpMm1EUENxeVdIMmww?=
 =?utf-8?B?QndRZFhiUThUMXNiTlVvRUFMbWJ5cThVL29xcURMTE4wRUhTdnZBWnhNZ0w3?=
 =?utf-8?B?NGs4TXFqckhwOVBuYTdkak1KaXNISmFDWFJRd3o2clViWXBwUDZSa3FINlpa?=
 =?utf-8?B?SGZMOFNrdEViTmRkWnZpN29OUnVwOWZYbUlUd1FicDZ1ZUZERVRSeEt0Wm9o?=
 =?utf-8?B?SDYvKzZaT0p2RjR0d00yVWFPdlZjNlhwUEx1UjJpbFZyVXUwTUJyY2ViZzNt?=
 =?utf-8?B?YnBCOEx3OWYvUm5ZWmZ3d1BCU2p5SzhpK04vQnRBNXl3WFdUZVZEZzZTVTdT?=
 =?utf-8?B?YmJZeFdnNEE3a1FCSkVKY3JaNkxTMng1Y3h1N3FRVUI2SUYyRUF4L0t1d0ww?=
 =?utf-8?B?aTJuRTFLNW1EbG0ydDRVbmkrWDB4SGJzT3RoVEdFeDI2amJwRXE4RFhMQzRz?=
 =?utf-8?B?azJkK0JvZUI1WmhOdDQzMDJqU1ZWRjVhamwrU2VsRnUwc1paN2JQdmRkMXBw?=
 =?utf-8?B?NjVBTlVHQTUxQXBEZWJiclU1ek96NisySWdwbDFVTWxpNFkvbUZLWWFOMG5k?=
 =?utf-8?B?VEowejNBcTl6bElzYUQ2TlVUWXdOb2V5amErVm81NmU5UzRmSDk3eWVNYnE5?=
 =?utf-8?B?VXR1cW8rNHBiU2U1RGNhb1NsamM2TmZSZkpnUHRWV2VrWjRBaURDNGZCbzhr?=
 =?utf-8?B?YkhhNjYrbGV4NzlHZUlvT0FBbGNBbTZWVksxVU1YUU5aNTU5ZEdjZ2gyOTBX?=
 =?utf-8?B?Vm0vQThoZnJUNlBFN05hSzVnWS9LK1Faa1RmQzN0bFA3M3RkTUU0aHE3bXho?=
 =?utf-8?B?NHVteTdaR1JjTk1Dd1BNcVpXMzQycVhPcGp3RnlPWHpWMndPMmF6Wnl4U01T?=
 =?utf-8?B?VEE9PQ==?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65095188-7d4b-4e13-6d1b-08dafd2175a4
X-MS-Exchange-CrossTenant-AuthSource: AM7PR07MB6705.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 09:08:57.8616
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yHNFBeru8SZl2YdwGj4bETWvL1EhRMOZLKARlW6qF+L7UtU7IOjH4Ld3hdsqGRn60bfecM3YaFyOzNNfXo8XbdQHg59bzPmtgfDTMwY2ExY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR07MB6314
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Russell,

 >> +	cn = of_get_cpu_node(cpu, NULL);
 >> +	if (!cn)
 >> +		pr_err("missing device node for CPU %d\n", cpu);
 >> +	cn = of_get_parent(cn);
 >
 > Doesn't this need to do an of_node_put()?
 >
 >> +	if (!cn)
 >> +		pr_err("missing parent node for CPU %d\n", cpu);
 >> +	common_rate = of_get_property(cn, "clock-frequency", 
&common_rate_len);
 >
 > And here too?

I have sent v2 in the meanwhile where I have refactored this part; 
please review:

https://patchwork.kernel.org/project/linux-arm-kernel/patch/20221221154213.24382-1-stefan.wiehler@nokia.com/

Kind regards,

Stefan Wiehler