Message-ID: <50af77ad-d12f-a6b3-7864-e8c9a5a7756e@axis.com>
Date:   Mon, 23 Jan 2023 10:19:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 4/4] ASoC: dt-bindings: ti,ts3a227e.yaml: add jack-type
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Astrid Rost <astrid.rost@axis.com>,
        Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Dylan Reid <dgreid@chromium.org>
CC:     <kernel@axis.com>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
References: <20230120102555.1523394-1-astrid.rost@axis.com>
 <20230120102555.1523394-5-astrid.rost@axis.com>
 <2d05a943-3510-5ee9-9906-247a6344190a@linaro.org>
 <0b0c0030-3587-5501-c7b2-eccbbe4551e0@axis.com>
 <21ea0402-c4f3-1344-d084-9f3138713abb@linaro.org>
From:   Astrid Rost <astridr@axis.com>
In-Reply-To: <21ea0402-c4f3-1344-d084-9f3138713abb@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVV4YlAxUTdSem1xaEp6bE9vUThEbEsrd0RWOUYxbElwZGZjUS8xaUlVREM2?=
 =?utf-8?B?d0hmQ1NzSG5EUVRPVnVQZ2RVdU9CMG5jSmU0SXBBUFl0ZlNBeEFqL0lFNTBx?=
 =?utf-8?B?VWZKdUJOWU5zRU1maVFuRnhucjBob3FPemdhMUFNRGFwcjBxUm41Y1l3ZFdx?=
 =?utf-8?B?dDQ3dkpXL2RXR2xQUFFTaGtBaHdId1ZyZ3BEKzAzNHlSeldnVW9FSnVrVW1l?=
 =?utf-8?B?R1NYUXBUckk2L2lSWGlMd2taUzJNUFNtbUZWN2dYVHpGV1QrTm5WQVQrdXNW?=
 =?utf-8?B?cWVNdXlmdEpycHJrNzk3YWY2WmVhWE1XVFhmVnB4Wkl3Z3lML2hucUdhbjFP?=
 =?utf-8?B?UnNyZkZTQzZaN2E1eEI1K3lDYUgvVHJMN1BMbHc2ZlBKM0VHVFVJZEFkRlAr?=
 =?utf-8?B?Z25ZbWY1b000N05DZnhzWlJRNWpkeGIzTmxTVlBsZEJoMDRCQTlIZUwwWVp2?=
 =?utf-8?B?RDg1MFZGT1hWcXFjQlcrUzFjeVFjdzA5M1cwN2VrUFhYY1BJQWFJMDRBS0ph?=
 =?utf-8?B?cFlCOGc5UHBJK0J4ZExiNUdUL1NjSWNRT0R6Q2tTam9ZbUlEZ0p1Vi8zT1JP?=
 =?utf-8?B?V2RCNDkxNHZaT1hXbEtpN1lBU2dISlRUNUhFS1ZtN1kydUF0L2xrU0ppczFU?=
 =?utf-8?B?L2E3WlQ4N3VFRDFJVWhuTEFBWjRFemliZFFBUkNUUE4wd0dibTZMS0l6UXBx?=
 =?utf-8?B?bzJnVFkwclFVVUJFYTVLRGVHTjlzcUVDY1QzMGM5OFN3eDF4K3JlTCtsWHkz?=
 =?utf-8?B?S0JZa2l0eWMxS1NFRXRhbWxheDFKVHltVmRtTUxzWTZyNldJc3RxRXZKck55?=
 =?utf-8?B?eVFnN2RlQnlDNnAwcUdZeDB4ZmJIcnBGeEYwbkJBWlIya1hkeDUvVzVITnB6?=
 =?utf-8?B?QjB1clN0ajlHTGlpU3lSUndyVERqeUR5WHl2NjVOVmRLaEsrVmdDQlhpVFpt?=
 =?utf-8?B?VWNWei9tNDlrc1UxYTlXYlpnZDZYM0pMZkFpTXI3Wi91WFU4WnNQRnhGRU5l?=
 =?utf-8?B?ZnpjaUlGTXk4ajN0QkFDUHBKdXF0S3lVZVhjUzlDMEFsa2lENFNQT1BMVUM4?=
 =?utf-8?B?eXVrQS9BdDhJVndLaTBhUUN0aWZqSzlINllzcXhFNlhyM0l1aDIzOGVZZTRD?=
 =?utf-8?B?TTBna09KbEVvek93Q3lKa21TY1pWeXdMelFOTmI0Q1FjVHp2RXBIOXNKVG5n?=
 =?utf-8?B?WUNhakp2blZvRnFaM1V1VWxJR1pXR0dRc2psMnhpS09kQkhCOG9kckdQU2xV?=
 =?utf-8?B?VzN0N0RtMUpZWWJqTWRMalhMSFc3aFRDYkFhTmI3WWswODcrTy8zTlkxUFB0?=
 =?utf-8?B?YjY2Uk9uZ1ZkczdiZjIzMWo4a1o3bkZLZnVpOTUxSmVvTGVJR250NXNmT1Vr?=
 =?utf-8?B?cTVkbWZLV3NCcEJGbTl4bFdxNk9pZTBScWZ3dTBVRGFMd2ZwSWlvUlJMV051?=
 =?utf-8?B?OGVGb2Z0bVF4ZDRlUUM5RzZzQy9Uckk3OGdUQ1k4Um0yZUlqdGFVNUtQZmc3?=
 =?utf-8?B?bTNyZWthRHUyYkZWaUUyeSsrZVp5bVBrTU9vb0xsK0Zlcnc3SGVVUUE4SndN?=
 =?utf-8?B?TWZWa21NNEVnNElhNjZsUmtPUmhGQlIwNENHaUdKQVlMOHRGazJQUGp0TnJT?=
 =?utf-8?B?eGdzcEJiYUprOE0xcHBIam10aFNrTjBwK3VzbGxXdTEwcWFsdFhwNlhwQXRC?=
 =?utf-8?B?Ri9RSmFHV2hHbXhrc05KK2FQTndPeHJ6VDd6ZGNYRWxMWmtQczNMUERMZFdM?=
 =?utf-8?B?ZEVkQ1dmTnZ3WFQ5OURnUnVRajVyVUNYM09rS0JtTWZ4ditKV2p6QUhUbXBl?=
 =?utf-8?B?cGFoOUxMNEgzdEJISUQwc05KdTJUZlR3STdqVDBWeks1SGtYK2xQSkE5VjZF?=
 =?utf-8?B?c29nS2pTMkdPY2RYKzJJMzlvdUphczJUdWxaSjBHOWx3QXNPQW5icDFHaDhB?=
 =?utf-8?B?RDU5WWlpZklsUmVNMS9JNXlGWlFFdEtVSzhFL1FHNEthNWZ4MkphcU1IejNa?=
 =?utf-8?B?NUZhSEJPaHovMFpxZTF1eERhRXdLSHRkTmtNUkwzNWRPbTVnTVg1OU9rNlo0?=
 =?utf-8?B?NFZFc1R0MDJIaCtod0RLRzh0R29PUk9YQ3pNWUlnTlZzV0pNM1QyTkFoeFNn?=
 =?utf-8?Q?mT0sGKQLPtEl+f1bR0LnsOEyy?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4149c2b2-796c-4a0c-4641-08dafd22ea97
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB9467.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 09:19:23.4094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X46inwF5e6mevEKFxiFCLS/peQTdQeHTE5+DzQW490Uot7bY8aBGOvWfgKews0dDz7wvIPFigidazv6pwXQF+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR02MB8652
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On 1/23/23 10:05, Krzysztof Kozlowski wrote:
> On 23/01/2023 09:39, Astrid Rost wrote:
>> Hello Krzysztof,
>>
>> On 1/22/23 15:16, Krzysztof Kozlowski wrote:
>>> On 20/01/2023 11:25, Astrid Rost wrote:
>>>> Add jack-type: Bitmap value of snd_jack_type to allow combining
>>>> card drivers to create a jack for it.
>>>
>>> Subject: drop "yaml". We do not filename extensions to subject prefix.
>>> Nowhere.
>>>
>>
>> yes, true.
>>
>>>>
>>>> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml | 8 ++++++++
>>>>    1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
>>>> index 785930658029..1d949b805f98 100644
>>>> --- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
>>>> +++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
>>>> @@ -27,6 +27,14 @@ properties:
>>>>      interrupts:
>>>>        maxItems: 1
>>>>    
>>>> +  jack-type:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    description: Bitmap value of snd_jack_type to allow combining
>>>> +      card drivers to create a jack for it. Supported is
>>>
>>> Why the device would once support (allow) headphone and once not? Device
>>> either always supports them or never...
>>>
>>
>> If a device has two connectors (pink and green), one for the microphone
>> and one for the headset.
> 
> We talk about "ts3a227" here, which has always two connectors (pins)...
> unless you refer to the case when these are e.g. grounded?
> 

yes, that is what I meant.
I push a version, where I remove this.

> 
>> It would be easier to see from the available
>> events, which is which. But of course it is possible to give it good names.
>> My first approach was, that it returned all supported types, so no
>> devicetree change needed. But by colleges agreed that it would be nice
>> to remove unused flags. I am happy to remove it and someone who requires
>> it can add it.
>>
>>>> +        1 SND_JACK_HEADPHONE
>>>> +        2 SND_JACK_MICROPHONE
>>>
>>> minimum and maximum
>>
>> I do not understand this? It is a bitmap. I can put it as an
>> enum:
>>    - 1 # SND_JACK_HEADPHONE
>>    - 2 # SND_JACK_MICROPHONE
>>    - 3 # SND_JACK_HEADPHONE | SND_JACK_MICROPHONE
> 
> 
> Then maximum is OR of them, isn't it?

yes 1-3
> 
> Best regards,
> Krzysztof
> 

Astrid