Message-ID: <c6ef28cf-74cc-5912-d73f-822f57642038@linaro.org>
Date:   Mon, 23 Jan 2023 10:21:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add SM7150 GCC clocks
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Danila Tikhonov <danila@jiaxyga.com>, agross@kernel.org,
        andersson@kernel.org, konrad.dybcio@linaro.org,
        mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org
Cc:     linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        David Wronek <davidwronek@gmail.com>
References: <20230122192924.119636-1-danila@jiaxyga.com>
 <20230122192924.119636-2-danila@jiaxyga.com>
 <5f778c47-a1a3-70f2-78b8-107a11e31eeb@linaro.org>
In-Reply-To: <5f778c47-a1a3-70f2-78b8-107a11e31eeb@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/01/2023 10:11, Krzysztof Kozlowski wrote:
> On 22/01/2023 20:29, Danila Tikhonov wrote:
>> Add device tree bindings for global clock subsystem clock
>> controller for Qualcomm Technology Inc's SM7150 SoCs.
>>
>> Co-developed-by: David Wronek <davidwronek@gmail.com>
>> Signed-off-by: David Wronek <davidwronek@gmail.com>
>> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
>> ---
>>  .../bindings/clock/qcom,sm7150-gcc.yaml       |  69 +++++++
>>  include/dt-bindings/clock/qcom,sm7150-gcc.h   | 193 ++++++++++++++++++
>>  2 files changed, 262 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml
>>  create mode 100644 include/dt-bindings/clock/qcom,sm7150-gcc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml
>> new file mode 100644
>> index 000000000000..a0105e11fdb8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm7150-gcc.yaml
>> @@ -0,0 +1,69 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,sm7150-gcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Global Clock & Reset Controller on SM7150
>> +
>> +maintainers:
>> +  - Bjorn Andersson <andersson@kernel.org>
>> +  - Danila Tikhonov <danila@jiaxyga.com>
>> +  - David Wronek <davidwronek@gmail.com>
>> +
>> +description: |
>> +  Qualcomm global clock control module provides the clocks, resets and power
>> +  domains on SM7150
>> +
>> +  See also:: include/dt-bindings/clock/qcom,sm7150-gcc.h
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,sm7150-gcc
>> +
>> +  clocks:
>> +    items:
>> +      - description: Board XO source
>> +      - description: Board XO Active-Only source
>> +      - description: Sleep clock source
>> +
> 
> If you started your work from the most recent bindings (e.g. sm8550) you
> would have saved one iteration and one set of review...
> 
>> +  '#clock-cells':
>> +    const: 1
> 
> Drop entire property, it's coming from gcc.yaml.
> 
> 
>> +  '#reset-cells':
>> +    const: 1
> 
> Ditto
> 
>> +
>> +  '#power-domain-cells':
>> +    const: 1
> 
> Ditto
> 
>> +
>> +  reg:
>> +    maxItems: 1
> 
> Ditto
> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
> 
> Drop reg
> 
>> +  - clocks
>> +  - '#clock-cells'
>> +  - '#reset-cells'
>> +  - '#power-domain-cells'
> 
> Drop these three.

BTW, all these changes above were not in your v1 so it is weird to see
them here now...

Best regards,
Krzysztof