From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH] f2fs: allow set compression option of files without blocks
Date:   Mon, 23 Jan 2023 17:46:01 +0800
Message-Id: <20230123094601.32940-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a+Df6vxTxX5QEb7EV6RzGb1K1F12rPvPZ29N9FGOZkfFmkLjN4yfvFMfTbgD?=
 =?us-ascii?Q?wBEJlzwfgYDzG/ZjBLbouLsQLisnlFqao1hpA4HWDpLLe6boH31ub8As/1s8?=
 =?us-ascii?Q?QDbf50w1rKdNtdYQ/XgMZFV0XsiH0yTyYZIng8Wz6MpDg596qtk+ql+PUQOs?=
 =?us-ascii?Q?ccoBC6rFQ278Uwl6aaAA9COjK4XXKs2oAanp/6i73x4yHcOPxzunWKxcTUfO?=
 =?us-ascii?Q?2Ii0gf8tLEX2ArasDZDOx4LgPpM0+e76/InUDHwihGrBqe/2cZxYAO8QOz4A?=
 =?us-ascii?Q?E8mgAcJCyT4n/dFf2GOEqL8jDJXmBLZlB5MvevctwxXL89M8GNskXj2V8xRO?=
 =?us-ascii?Q?pwsGkBcZMuJIotF4M94wFn8Agv17VFzfb3cdIEYJnc4yfkS3Za/mgDynBnRg?=
 =?us-ascii?Q?+FA/m4c5XqDYL7i3Dm1hI/0NfxJqB0Qa1Ahe8sBLx7gny3pc5QZSk6vkmefk?=
 =?us-ascii?Q?0tzFrA/tDYkF6NNZOq+bP7YzCiKSuwbep36NuyrMyw3TiRKx6+8+SFgywV18?=
 =?us-ascii?Q?XBLFuAvXLh/82J/rkJpz7cH8iC0nlkLAL9gi8LnTx6K1wsJ1oc/Fsx7S6keQ?=
 =?us-ascii?Q?Ia8fgM6QnANJbkXUQLTx496RME/YbC9/qgJub3fMqDKnZJJPLrXf/jpPmAaz?=
 =?us-ascii?Q?T2uHGcn54gaBNY0tNy5OlN2RFClQ79GfxWpr5Ks6IplKxRpQt4geqIlYXHbN?=
 =?us-ascii?Q?1lpe9Ib4NyejlkQwTDClIV5CnOdSgESx7HwbRorvKIfag+FFk/24IXt7oSVs?=
 =?us-ascii?Q?+eNySmxoNUt5+h90GDGcnO3pqO1ypslZymV+3JnaaWDkTyYIyhzIP3KIN5Zo?=
 =?us-ascii?Q?wQr5UNwB44pxpVbYYCnLbOnKwc20L/VpcYSnClPPWeBfTV6vzHqyc383UqDB?=
 =?us-ascii?Q?K5kGdwxUqB4ET14wnCelhlB+t/v1A+fft13bAvZmLW8P6XtFSNsw+8nhPRb2?=
 =?us-ascii?Q?6EtfOJRadriLu4UfzLcOhPZm1BPEdpqiquaTdlOQhBdg2s4+913zZ6DcZ67h?=
 =?us-ascii?Q?duL6CQR8LvmXUwZ9LfTTnnwb96UY3zbvNvMQ7yc0cPcBgLnlRPuvZLzHyhn0?=
 =?us-ascii?Q?pMNrOldnoFj+d3G8Avr4o7qgx8mubv3JgtPwj6h+vRCv1m1TGY3Z+pvUu4f+?=
 =?us-ascii?Q?I+OUvK3A8Y0OWQOgsIQx1WgH8DKK6dFgWvmyOiUN9nd+C4TNdbj0faSTgUSO?=
 =?us-ascii?Q?D1Tj5gzdGrEswVLpVWTI2Vwt5FHR69oFlKhYavDKyoXSqPGCKhOnVE5TXo4L?=
 =?us-ascii?Q?ZAS58wcLq3Sv8y8hJym8lArKqiGli+1NWxLbR6aaATP4h0P3pGPYMzG7wUjs?=
 =?us-ascii?Q?HkfY++rqndmJ8G2S0yVFTVoaqSBCclWvn/m/4CUNIudscHkOvYsOjGs92hNR?=
 =?us-ascii?Q?Jcf3BepEeZJD57uK5gq+iWt5AgUO9Ml0NzZM6saSrptdYH/oz14xGi9l/4Pz?=
 =?us-ascii?Q?tN0JxuBUnbvsf33xfOrbMy8RhtRk9dOfsXCU5fYENoQnh/ICYMmpmWigJ+Wg?=
 =?us-ascii?Q?x8+GAXrs33VG9quZ+z+4qhCDAB4PzzyleNn6yorW+ciLzMpU3wrKsIbf6zPJ?=
 =?us-ascii?Q?xzRax5HtpW98PqyIV9AoXvKLEntclChBUk5TIX3e?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd66e5a6-2872-4427-682d-08dafd26a96e
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 09:46:12.2171
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3u9YkSieTPgzpjqhBTivHb9pnWbT2NoNfeyMikPv0QeeTZ6KLlFGRsh9nzRK8BveD0aak8iJPqxyJoexX+SGeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6113
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Files created by truncate have a size but no blocks, so
they can be allowed to set compression option.

Fixes: e1e8debec656 ("f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index b3bcb50490bd..fda04c37b48c 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3990,7 +3990,7 @@ static int f2fs_ioc_set_compress_option(struct file *filp, unsigned long arg,
 		goto out;
 	}
 
-	if (inode->i_size != 0) {
+	if (F2FS_HAS_BLOCKS(inode)) {
 		ret = -EFBIG;
 		goto out;
 	}
-- 
2.25.1