MIME-Version: 1.0
References: <20221123025141.4012-1-jaimeliao.tw@gmail.com>
In-Reply-To: <20221123025141.4012-1-jaimeliao.tw@gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 23 Jan 2023 11:44:53 +0100
Message-ID: <CAMuHMdU7f25OFOg7ek-37fFQbQ7Wupo2aPgAdA5QrY2HMp5d=g@mail.gmail.com>
Subject: Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address
To:     JaimeLiao <jaimeliao.tw@gmail.com>
Cc:     linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org,
        jaimeliao@mxic.com.tw, leoyu@mxic.com.tw, alvinzhou@mxic.com.tw,
        juliensu@mxic.com.tw
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Jaime,

CC linux-renesas-soc

Thanks for your patch!

On Wed, Nov 23, 2022 at 3:55 AM JaimeLiao <jaimeliao.tw@gmail.com> wrote:
> In the RPC manual mode, if the data direction is not set
> (such as the flash erase command), the address misses the
> setting.

This patch never received review comments.
As of commit fff53a551db50f5e ("memory: renesas-rpc-if: Correct QSPI
data transfer in Manual mode") in v5.16-rc1, RPCIF_SMADR is written
before the switch() statement, hence this patch can be ignored.

See also
https://lore.kernel.org/all/CAMuHMdWpvuC2Cm41jCQm+rT8MZB5GN+Z0bPz941QzsHX17Ux-g@mail.gmail.com

> Signed-off-by: JaimeLiao <jaimeliao.tw@gmail.com>

> --- a/drivers/memory/renesas-rpc-if.c
> +++ b/drivers/memory/renesas-rpc-if.c
> @@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
>                 }
>                 break;
>         default:
> +               regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
>                 regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
>                 regmap_write(rpc->regmap, RPCIF_SMCR,
>                              rpc->smcr | RPCIF_SMCR_SPIE);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds