From:   Laurent Vivier <lvivier@redhat.com>
To:     linux-kernel@vger.kernel.org
Cc:     Gautam Dawar <gautam.dawar@xilinx.com>,
        =?UTF-8?q?Eugenio=20P=C3=A9rez?= <eperezma@redhat.com>,
        netdev@vger.kernel.org, virtualization@lists.linux-foundation.org,
        Eli Cohen <elic@nvidia.com>, Cindy Lu <lulu@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Parav Pandit <parav@nvidia.com>
Subject: [PATCH v2 0/1] virtio_net: vdpa: update MAC address when it is generated by virtio-net
Date:   Mon, 23 Jan 2023 13:00:21 +0100
Message-Id: <20230123120022.2364889-1-lvivier@redhat.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
UI-OutboundReport: notjunk:1;M01:P0:2nLqAPfkmz4=;ME1dtv68aATFXykiq24doQVfAG3
 px94zx7FpfJojGIffpqGI0gEddgCxUoyUu8xMFtMPFPpT4e5J9ZPG14SQ/H2N+WLxDDvBqjSp
 ZHpp2KQE5av3925WWsb7Gvne9hhW/wciGi9ASYBT0uQNRLY1tK46uTrcE4OYAML9dqFRnVt2U
 cNtleIPJgELbjwenHR8tIkjMjInKxTXX+2YJoa6Ly7lcIHjQ5LrNF5s1SXDZ0nWiQCfncDRFM
 LXIDUd1zMiZbFMGWihNztjI18Ky4YbUgVuv4Pp5+Dgn2Tp9I2BuROtn2WJ33H851L85zyaCPD
 eEXuqVaLe2ZX9dV2Pn56NcKClLNNQLVtxexhk+ybjqGZt5FI+shevGlBPBaj9nMHL6Edqmimk
 MjjgB9fW7ZzPOYFmQd3tco0gHFHeAI/f0yMdUYgyUyhv5UUNPcFFwpn/JyNiEPVWfitGUxM7F
 w6t7ydLW0gKDH/nFl869B8VqfdsrZeCAroz9CpsuoOkW8RYtHjgyISUVgysuONhbDnbK1s6sv
 Sj9HLDmc05t9+wf5slzHVgDl7fg2V1kaMaOMdf7fyfZ7mJtVrU2mTpgZfYfrmTmGAiWGyPaM6
 1GwOJardTxWUgLh0jS1OLVk2iTcIWuSKY5YTb2iM3XPk7LPd6VWBdWcb9fT4ErYttFRXsm9z8
 t64BYa8PFMOCvrkqE4GwoyLYgJkgoXZ17IPLFiTpzA==
Precedence: bulk

When the MAC address is not provided by the vdpa device virtio_net
driver assigns a random one without notifying the device.
The consequence, in the case of mlx5_vdpa, is the internal routing
tables of the device are not updated and this can block the
communication between two namespaces.

To fix this problem, use virtnet_send_command(VIRTIO_NET_CTRL_MAC)
to set the address from virtnet_probe() when the MAC address is
not provided by the device.

v2:
  - remove vdpa_sim related fixes
  - check virtio_has_feature(vdev, VIRTIO_NET_F_MAC) rather than
    addr_assign_type

Laurent Vivier (1):
  virtio_net: notify MAC address change on device initialization

 drivers/net/virtio_net.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

-- 
2.39.0