Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Date:   Mon, 23 Jan 2023 13:32:55 +0100
From:   Robert Richter <rrichter@amd.com>
To:     Alison Schofield <alison.schofield@intel.com>
CC:     Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/mbox: Add debug messages for supported mailbox
 commands
Message-ID: <Y85+dwjO9JjtFtGa@rric.localdomain>
References: <20230119130450.107519-1-rrichter@amd.com>
 <Y84dleBbsQhE0Dic@aschofie-mobl2>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y84dleBbsQhE0Dic@aschofie-mobl2>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 12:33:00.8059
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 210aa652-839e-4901-8666-08dafd3df733
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT039.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6733
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alison,

On 22.01.23 21:39:33, Alison Schofield wrote:
> On Thu, Jan 19, 2023 at 02:04:50PM +0100, Robert Richter wrote:
> > Only unsupported mailbox commands are reported in debug messages. A
> > list of supported commands is useful too. Change debug messages to
> > also report the opcodes of supported commands.
> 
> Hi Robert,
> I wonder if you can get this info another way. When I try this 
> loading cxl_test today, I get 99 new messages. Is this going to
> create too much noise with debug kernels?

There are 26 commands supported by the driver, so I assume there are
at least 4 cards in your system? To me the number of messages looks ok
for a debug kernel. And, most kernels have dyndbg enabled allowing to
enable only messages of interest? Esp. if card initialization fails
there is no way to get this information from userland. The list of
unsupported commands is of less use than the one for supported. That
is the intention for the change.

Thanks,

-Robert