Date:   Mon, 23 Jan 2023 16:34:27 +0100
From:   Henrik Grimler <henrik@grimler.se>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Inki Dae <inki.dae@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Kukjin Kim <kgene@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        replicant@osuosl.org, phone-devel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        Martin =?iso-8859-1?Q?J=FCcker?= <martin.juecker@gmail.com>
Subject: Re: [RFT 05/11] ARM: dts: exynos: add ports in HDMI bridge in
 Exynos4412 Midas
Message-ID: <Y86pA6xo9EttJJ6g@L14.lan>
References: <20230120155404.323386-1-krzysztof.kozlowski@linaro.org>
 <20230120155404.323386-6-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230120155404.323386-6-krzysztof.kozlowski@linaro.org>
Precedence: bulk

Hi,

I see you have already merged this, but FWIW HDMI works as well as
before on exynos4412-i9300, so:

Tested-by: Henrik Grimler <henrik@grimler.se>

Longer explanation: HDMI output only works on i9300 if MHL cable is
attached before device boots, so probably bootloader sets up some
settings that the sii9234 driver does not handle (correctly) if cable
is hot plugged.

Best regards,
Henrik Grimler

On Fri, Jan 20, 2023 at 04:53:58PM +0100, Krzysztof Kozlowski wrote:
> The SII9234 HDMI bridge expects ports property:
> 
>   exynos4412-i9305.dtb: hdmi-bridge@39: 'ports' is a required property
>   exynos4412-i9305.dtb: hdmi-bridge@39: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4412-midas.dtsi | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
> index 8e1c19a8ad06..a626d33d1330 100644
> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
> @@ -273,9 +273,16 @@ sii9234: hdmi-bridge@39 {
>  			interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
>  			reg = <0x39>;
>  
> -			port {
> -				mhl_to_hdmi: endpoint {
> -					remote-endpoint = <&hdmi_to_mhl>;
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					mhl_to_hdmi: endpoint {
> +						remote-endpoint = <&hdmi_to_mhl>;
> +					};
>  				};
>  			};
>  		};
> -- 
> 2.34.1
>