From:   Hariprasad Kelam <hkelam@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "saeedm@nvidia.com" <saeedm@nvidia.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "maximmi@nvidia.com" <maximmi@nvidia.com>,
        "tariqt@nvidia.com" <tariqt@nvidia.com>,
        "moshet@nvidia.com" <moshet@nvidia.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "maxtram95@gmail.com" <maxtram95@gmail.com>,
        Naveen Mamindlapalli <naveenm@marvell.com>
Subject: Re: [net-next Patch v2 1/5] sch_htb: Allow HTB priority parameter in
 offload mode
Thread-Topic: [net-next Patch v2 1/5] sch_htb: Allow HTB priority parameter in
 offload mode
Thread-Index: AQHZL0QCO87Fr8OC60ePabgspZQyHQ==
Date:   Mon, 23 Jan 2023 16:01:53 +0000
Message-ID: <PH0PR18MB4474A678CC3A6AAF0D69CDCBDEC89@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20230118100410.8834-1-hkelam@marvell.com>
 <20230118100410.8834-2-hkelam@marvell.com> <Y8zz/eDMsXEr5KMk@unreal>
In-Reply-To: <Y8zz/eDMsXEr5KMk@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/228mO6sdFQ9i/9ZXs6i7+tpl4TFZsoWyKOn4HQyvThNmBwqcWMzfaHCxuFh?=
 =?us-ascii?Q?OLTkh8n9o2C2N1PrsctioDLCg0gADVDhp7ydUao1OJJpie9mSobhHCvk94BB?=
 =?us-ascii?Q?1V8CoE52RCMv/Hd0xRZTDOGy2a7SVaeArhVUMouRhgIOTlBAOsdAcemhrg/d?=
 =?us-ascii?Q?w5gJ9Ctaeiw/NMrqPdoksW3XscK1Qtk+1GqQhs8xtyO0rVzoYExyyUX2/nWG?=
 =?us-ascii?Q?MjM9ykHaUuNtPVx74aK0PAXe4GHgal7QltI47GCb7CF1JnXId6Rr4uPWshXy?=
 =?us-ascii?Q?tAdllYQjfEjmA72CzOcZFh09a1jhG4tydvh4hCQus6k4uY0j/o5pO/AqfDGs?=
 =?us-ascii?Q?s4+ZYJYpYuiiaomeA3Ev2Uv/t310zBsYpqCqxxSFs8v1QIt2YUIalOptC0TG?=
 =?us-ascii?Q?rEDjYz4ykI0zFbWOaiRIbIcm5w+QDMpG+1BX07Sn9CLc6qqIMvNbmCDm0xJo?=
 =?us-ascii?Q?NruoGGeBm6xiZVDoMqqmQqeH175Pz/ZvJt3hFb/YXNRU4ImCR5hPRpTacJ9i?=
 =?us-ascii?Q?O4o6Sd0kUeTjrOjtaAdRWZlxkrRzEeKLJ1ui21/a1+V3UIWSKB+DdC0KEnwe?=
 =?us-ascii?Q?+y1BR3G/ChD252UB20TawhdHl8r+haICCy1UjoS+eNBMHAx80UFDnJZO/w0k?=
 =?us-ascii?Q?8+TDgmNIHQDOfQtOd2+NbuF4IS/QqcxDktHKI6Da9/7pIh7e4z9vqTF5sDvT?=
 =?us-ascii?Q?Ab0PeDkOLzZjEl+OWqFOfAkUzdD7hgXk+eGIazgaLWdYa9rJQrXNfPZOGaoE?=
 =?us-ascii?Q?MAr2M+ssNArZO3+DYcSnidJkdFyRxg9H+mtHppPsHbkG16eRYOwrHN7LMpHU?=
 =?us-ascii?Q?iR6aWFfjePsbj3j+OEDafzzQFtW9Wjr7902N3E5NlDCbrtoiozVijV8aiT+f?=
 =?us-ascii?Q?Fv6/bPEreg/tSXR8F0zvM3IOzF7O56fZYHl1ujDXuE4+UNRejns3FmlI9axR?=
 =?us-ascii?Q?uFGuOBn0RRCQerBqPLDAwnYIcg6aZWTxujYcQFWLWGSZESHBC6V/gwzLrQbO?=
 =?us-ascii?Q?UHcfwh77awOzYiVvd3PPKx6qqAvzBFKCBfiDJoDhSoMO9sXqAgfI8b6r/FxT?=
 =?us-ascii?Q?safGM5NBbd3DTgJN0lSFIcZuCrw0YkVdL+gx01MJ0Wf6bhK5q7fjoTCnL1Vt?=
 =?us-ascii?Q?F8mWEELhoQ3fNf2Uk/zVa6fX4kPyWzBg6asHe2idiA3iXDjpVNQaWrirJeQS?=
 =?us-ascii?Q?FSBpXPP+fIJoLMa1UrryM124pVi3akng4INCNs0//87MVaXnX1hVYhfMJACI?=
 =?us-ascii?Q?0wFTrdytxxkcJ5csoQCit184z3b7aYLlqK2SwvF3YhMLQaQpzVzZ38Yomgd4?=
 =?us-ascii?Q?fFDarB+LKcf4Av+xBGZOZjgpzrwoSiQJHibr4vnUhL+FIxbXwTzt2pUz/guP?=
 =?us-ascii?Q?W64DuOfydOYFLFemx9nlteJJQFwkERKaxyzHYJcpWFaVHlCJzf/NroNH+MbG?=
 =?us-ascii?Q?vxX0JRSjmUB5JPWBxrnQGTMBh2eSODiIjMvGyf6Mll7JUO4wCIafVNTqsoeY?=
 =?us-ascii?Q?bSSflJXP2nQUbq2h3LzG8TPBKxfZkUySTS36YZXZnkm2rMnZP2UMb+0ZaQMj?=
 =?us-ascii?Q?telZqtPP36rbVZZacS+BARh+K60oXzPY/frab61G?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cad35cc-cd82-44fa-f955-08dafd5b2512
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2023 16:01:53.2041
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wNb/QAyDlGMrfKrH2jezheLkTZLBY7R9O4lK7gfzWLUD+wDkyJ08dDA2KGTsDwkGCZ6S9+p/ntOUtZKmMrF4Lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3490
X-Proofpoint-ORIG-GUID: Si240MXH1UUVMwohBj0_hkZgQUeoVtnH
X-Proofpoint-GUID: Si240MXH1UUVMwohBj0_hkZgQUeoVtnH
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-23_11,2023-01-23_01,2022-06-22_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Wed, Jan 18, 2023 at 03:34:06PM +0530, Hariprasad Kelam wrote:
> From: Naveen Mamindlapalli <naveenm@marvell.com>
>=20
> The current implementation of HTB offload returns the EINVAL error for=20
> unsupported parameters like prio and quantum. This patch removes the=20
> error returning checks for 'prio' parameter and populates its value to=20
> tc_htb_qopt_offload structure such that driver can use the same.
>=20
> Add prio parameter check in mlx5 driver, as mlx5 devices are not=20
> capable of supporting the prio parameter when htb offload is used.=20
> Report error if prio parameter is set to a non-default value.
>=20
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> Co-developed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> ---
> v2*  ensure other drivers won't effect by allowing 'prio'
>      parameter in htb offload mode

<...>

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/qos.c=20
> b/drivers/net/ethernet/mellanox/mlx5/core/en/qos.c
> index 2842195ee548..e16b3d6ea471 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/qos.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/qos.c
> @@ -379,6 +379,12 @@ int mlx5e_htb_setup_tc(struct mlx5e_priv *priv, stru=
ct tc_htb_qopt_offload *htb_
>  	if (!htb && htb_qopt->command !=3D TC_HTB_CREATE)
>  		return -EINVAL;
>=20
> +	if (htb_qopt->prio) {
> +		NL_SET_ERR_MSG(htb_qopt->extack,
> +			       "prio parameter is not supported by device with HTB offload=20
> +enabled.");

NL_SET_ERR_MSG_MOD()

>> will add this change in next version.

Thanks,
Hariprasad k

Thanks