Date:   Mon, 23 Jan 2023 17:11:13 +0100
From:   Jakub Jelinek <jakub@redhat.com>
To:     David Laight <David.Laight@aculab.com>
Cc:     "'Michael.Karcher'" <Michael.Karcher@fu-berlin.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
        Segher Boessenkool <segher@kernel.crashing.org>,
        Rich Felker <dalias@libc.org>,
        Yoshinori Sato <ysato@users.osdn.me>,
        John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        "jakub@gcc.gnu.org" <jakub@gcc.gnu.org>
Subject: Re: [PATCH: 1/1] sh4: avoid spurious gcc warning
Message-ID: <Y86xofsIk3NzidQO@tucnak>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <52952170-f1a9-89a0-e307-f974ce2b7977@fu-berlin.de>
 <c411961861df4ae4b011317ff2c3c7df@AcuMS.aculab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c411961861df4ae4b011317ff2c3c7df@AcuMS.aculab.com>
Precedence: bulk

On Mon, Jan 23, 2023 at 04:06:27PM +0000, David Laight wrote:
> From: Michael.Karcher
> > Sent: 22 January 2023 00:15
> > 
> > Prevent sizeof-pointer-div warning in SH4 intc macros
> > 
> > Gcc warns about the pattern sizeof(void*)/sizeof(void), as it looks like
> > the abuse of a pattern to calculate the array size. This pattern appears
> > in the unevaluated part of the ternary operator in _INTC_ARRAY if the
> > parameter is NULL.
> > 
> > The replacement uses an alternate approach to return 0 in case of NULL
> > which does not generate the pattern sizeof(void*)/sizeof(void), but still
> > emits the warning if _INTC_ARRAY is called with a nonarray parameter.
> > 
> > This patch is required for successful compilation with -Werror enabled.
> > 
> > The idea to use _Generic for type distinction is taken from Comment #7
> > in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108483 by Jakub Jelinek
> > 
> > Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
> > ---
> > 
> > diff --git a/include/linux/sh_intc.h b/include/linux/sh_intc.h
> > index c255273b0281..d7a7ffb60a34 100644
> > --- a/include/linux/sh_intc.h
> > +++ b/include/linux/sh_intc.h
> > @@ -97,7 +97,7 @@ struct intc_hw_desc {
> >  ???? unsigned int nr_subgroups;
> >  ?};
> > 
> > -#define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
> 
> FWIW it is (currently) enough to add 0 to the top or bottom
> of the division.

If you don't want the warning at all, sure.  But if you want the compiler
to warn if you use the macro on a (non-void *) pointer rather than array,
what has been posted is needed.

	Jakub