Date:   Mon, 23 Jan 2023 09:49:58 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     James Houghton <jthoughton@google.com>,
        David Hildenbrand <david@redhat.com>,
        Muchun Song <songmuchun@bytedance.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 21/46] hugetlb: use struct hugetlb_pte for
 walk_hugetlb_range
Message-ID: <Y87Ixj5GJJKz7a/U@monkey>
References: <Y8hITxr/BBMuO6WX@monkey>
 <CADrL8HUggALQET-09Zw3BhFjZdw_G9+v6CU=qtGtK=KZ_DeAsw@mail.gmail.com>
 <Y8l+f2wNp2gAjvYg@monkey>
 <CADrL8HVdL_NMdNq2mEemNCfwkYBAWnbqwyjsAYdQ2fF0iz34Hw@mail.gmail.com>
 <Y8m9gJX4PNoIrpjE@monkey>
 <Y8nCyqLF71g88Idv@x1n>
 <CADrL8HXkdxDdixWRKNw6RFdbiBX-Cb1Lk7qxg6LdeNywbMOaOA@mail.gmail.com>
 <Y8nNHKW0sTnrq8hw@x1n>
 <Y8nV2TvMK12yTPzE@monkey>
 <Y86lZxGEQOBv3Hmw@x1n>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y86lZxGEQOBv3Hmw@x1n>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jce9PEtGk2Fi+Mv7MZZY+IQkfimZkv7C57eHgg6L9ZTNgADERSw+YRJE+A0F?=
 =?us-ascii?Q?ubrcQr4/xN0pBNm468+Glcek4ogqhOzMCvlZy1V91hGCC19grVsUqhLtQZB/?=
 =?us-ascii?Q?f0rz/KTBfsbw9TYUMNZyT5B/ShKmI1IehxiatRFDFlu97Bq4dAr8lahkecFq?=
 =?us-ascii?Q?7jmOroeHErUtod0gztfdQymGVCHIFBXrA/BRKHUNhC3Hgsw8u8hABy71d6/a?=
 =?us-ascii?Q?gHkrke/cmO+5qQr2ImiUbNurMyTsoKVEpSJokxfk3SMEbcGWQlGJRRGQhthE?=
 =?us-ascii?Q?BqFwWRVZVQUpfXBYb0Hs9XK3kNj3kjd12CUqub4in1wACF2sb5+rMgJrdVQ0?=
 =?us-ascii?Q?3Q4hiu9lmZzd6gAkrVILtmMrZhElVdVgWG4Fc2g4gUAtmMNwmzhvYA6jsCII?=
 =?us-ascii?Q?w1sMqFk4iQSbISDk64Ow2B5TgLBpAiSx4axLlFuxryb6czYug/Eaum1xecRe?=
 =?us-ascii?Q?hQ8w8dAvAZR8IsvVb45sYX2C4TR1dTCaS0GG1yq0u9v8nn9suA24mxX0g6Wr?=
 =?us-ascii?Q?hY6TeWsNf1sAjJs3anH3RQLO87zSmZcp5QUV0Ik4zXTOKOASZTDUBI6XGDUq?=
 =?us-ascii?Q?0U77xomr7/8e18wZzkd14p2bjVAaQLPaVHdMg84K1sSCtKD83rAvT/JZ5CCv?=
 =?us-ascii?Q?+48dQumjIriGrcFkbLzAnoZ5VF21kmrSY/rXO9zlipyK5kVIsQ9vPnmohpuP?=
 =?us-ascii?Q?w7pqZEsHr9ql798uadWQ+mMcQu89zx3JKKmPUPmwDDIiPGN1bIitqp4HOnSx?=
 =?us-ascii?Q?a5UwNhupY4ujK6ZwdSXY0pdH8j0ib1mGL1gR1qJy7XY5VLSNlodajNE0oFNv?=
 =?us-ascii?Q?DEy/jJU3DJ6oy4fJ7bqhZmrMKzLa+NKfNzjHHuyeZfa/TAiBFM0BHjv/pMhs?=
 =?us-ascii?Q?+42RPzLWqh3pB5HfSIftvp1VMD7KujXiQNRxIBX1ygZz3mZ4lwQkLIBDD7UW?=
 =?us-ascii?Q?gfFWk+EBoNUflau9XR5ZeC0Q4cZytgKB6yfLeoAkdc3O93ee/FhUEDY+LXSu?=
 =?us-ascii?Q?OhqDVLXouiUIXjkjxL88iPaMO5UD1D2zb3kJ0XExfMybNefhfcpcdBaBsnOH?=
 =?us-ascii?Q?IOIlvkTjNjod3VGowJDRhGBvUj7FBPJ90fLXZlq1aV2XpYMrFW231SQbgr0Z?=
 =?us-ascii?Q?7qn8azFGlfGAz9iLPwqFeJ+g0SsNDTYvbU/2yV40uL/qvvUhWBBwGhM38IT/?=
 =?us-ascii?Q?WlKLVGfsFRE04cENDzO6GeJoLgIxAvpMpVq1OKCqkPCmoNkMdLLo7KFIRCxc?=
 =?us-ascii?Q?S9n2157QLrjcrd+734HQbQphAz+ZtM2tkbcXmLvsO5lI+gXLGF0nQQLWVMRE?=
 =?us-ascii?Q?N2Ok+t5O6dLPZiMI7Qf55F5pV+hCnnSBrlHxnFGnj0DwIH1K2VSaiSCcefyY?=
 =?us-ascii?Q?ajpBfhAyCqxWq6Zei/rgBOtwctGIzrq94UgEYEUfgOQ5qTfZ8+0qjSlvWWs0?=
 =?us-ascii?Q?y6Fr2gIPaj7VP+bWS2e8Qcut2aneaKyqRUVrDNZ7b3xbhOsT7FKQwg/B5uQm?=
 =?us-ascii?Q?Q/cfus8nETXC2kTas+tjO5Cfi52Ao0IOmeumJ4Mq6XqJpqCLEdGGDFzSW91a?=
 =?us-ascii?Q?Hu4dGrdBznwyyCu3A7f0e0l0rytzRZRsI1RzhAi6xB0Z670SSmaAog0Jg/2V?=
 =?us-ascii?Q?2w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?WAbDEpQz9UBe1h0KLmF4AMkzLaQ7Z33lVGJt5svqxZaTMa2+zbTuZCmQqP5j?=
 =?us-ascii?Q?HA9bv6GhT40FrAvny96uCCfQ3lgKF5fosMW/xAa+ikjtr+dk+HSbfK/o/dn2?=
 =?us-ascii?Q?xewp3kNkMMm79/Drh3dkrPpDBftkBc5hAVn3M9oTYsMtrQi9AD1bq+HtQ4uL?=
 =?us-ascii?Q?jiWI9xVQfIspXW6CoIi4dts4dKBgQR+TkbH3ix0XXlC9ccEFKey2teKHL7OM?=
 =?us-ascii?Q?3WemNcByGfgEj2U3HnQ3BnAL41EFiFxXkoXbXk65PHuQNKLmeNvlI3Wtc3ds?=
 =?us-ascii?Q?5z+RFCpa1j2NCgtiBnoBdIWwwY7hhhAmhSdJYtAap+RxeI3LQrkkxMyi8wXh?=
 =?us-ascii?Q?qvxfOQC68WOraKy8mjvmHrHRXCLcq+RHfXrmXQbgM5RFFMqhNxBBmVv9ljmY?=
 =?us-ascii?Q?EhZh5aHIMfIRbPtVN0we3qOz5FjapNrcn4vkHwplkCmChfDg93AIoM+W+5YI?=
 =?us-ascii?Q?h08CYtQamLIAOa17yzkqnLgeZ0v7XzITiFeUa/PGTu5dcLNPpOKg4Ru6gkbb?=
 =?us-ascii?Q?9OnbT6IP+7hyDLNVKXpeWBlCG1kKXTPZxQIpTssQ9t+1fKc1z4V6iqr0Wmf5?=
 =?us-ascii?Q?0S4JR2hriyfuqMEhiXCs1UfllGz+tLiEeIhh4obRjJtDuYWVAGI6ki30f37t?=
 =?us-ascii?Q?Fx2vsMAtAa2u11pIelSMDauIgW2dgBiY2Yu7ylsl9IVdopbhnEv4tSWOlSaE?=
 =?us-ascii?Q?O2V0nhqMmdj9hTmMmhej6cssFzX7j/bPOSi1pIf1DbrydmY7f6/61UvY928I?=
 =?us-ascii?Q?rA5t13bZvg+u9dXHcWysWIBLYxYW4+i0XFLEQSwAvnfGlMxuE36F0Gc1HC04?=
 =?us-ascii?Q?dfv+kd+JARB5wK6ZVfSZg3ow/CmLaU3IQR8dDlBUhWRm0vQHUDXlvPpWmt3W?=
 =?us-ascii?Q?zgMBnYUaXMDfU3qWu1ImpTJHvCOIdbImxnTK0VydUb8GOOY609rgRgvE40De?=
 =?us-ascii?Q?Yqk8tRV9Kbbzj/Otyq0CSMcedeMR3aK3onViIY4eDVaHpQ6ZPrLpqAfMv1d3?=
 =?us-ascii?Q?3jsWbNaSFsAQbs/Gcs4cLwk3PbuAOBkGo+VRflzbF5YrKAFIVSLX/XIDvdi1?=
 =?us-ascii?Q?i9Tlm7fUIucm1Re4KTqQVrEx4Ila6GKLANX75Fztns2IGPdqf1yoT4qWn2AO?=
 =?us-ascii?Q?XN2392fPrB8iAhBCoz78XCZcPHWkr/5dGw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fea9578-0bbc-4ce8-ce73-08dafd6a40cd
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 17:50:02.6323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lHM6LzDWNX8C86/Dk9z+dymd5bGVlxZTNINGEHYQcxoTJdsAJcLhYplehLHFmedfcOKKeTwgczZgoQnK28opmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4968
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-23_12,2023-01-23_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=714 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301230171
X-Proofpoint-ORIG-GUID: N9Ywg_yWkLL8d0agpAN-yAaBuwRS_Vsz
X-Proofpoint-GUID: N9Ywg_yWkLL8d0agpAN-yAaBuwRS_Vsz
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/23/23 10:19, Peter Xu wrote:
> Hi, Mike,
> 
> On Thu, Jan 19, 2023 at 03:44:25PM -0800, Mike Kravetz wrote:
> > On 01/19/23 18:07, Peter Xu wrote:
> > > 
> > > Actually when revisiting the locks I'm getting a bit confused on whether
> > > the vma lock is needed if pmd sharing is anyway forbidden for HGM.  I
> > > raised a question in the other patch of MADV_COLLAPSE, maybe they're
> > > related questions so we can keep it there.
> > 
> > I can quickly answer that.  Yes.  The vma lock is also being used for
> > fault/truncation synchronization.  Commit e700898fa075 make sure it is
> > even used on architectures that do not support PMD sharing.
> > 
> > I had come up with a rather ugly method of using the fault mutex for
> > fault/truncation synchronization, but using the vma lock was more
> > elegant.
> 
> Thanks for answering, I'll need to read some more on truncation later.
> Before that, since COLLAPSE will already require the i_mmap_rwsem write
> lock already, does it mean it is naturally race-free against truncation
> even without vma lock?

Yes, and thanks for making me take a closer look at COLLAPSE. :)

-- 
Mike Kravetz