Date:   Mon, 23 Jan 2023 13:12:33 -0500
From:   Gregory Price <gregory.price@memverge.com>
To:     Oleg Nesterov <oleg@redhat.com>
Cc:     Gregory Price <gourry.memverge@gmail.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
        krisman@collabora.com, tglx@linutronix.de, luto@kernel.org,
        peterz@infradead.org, ebiederm@xmission.com,
        akpm@linux-foundation.org, adobriyan@gmail.com, corbet@lwn.net,
        shuah@kernel.org
Subject: Re: [PATCH 3/3] ptrace,syscall_user_dispatch: add a getter/setter
 for sud configuration
Message-ID: <Y87OEdDXwZG8pmmE@memverge.com>
References: <20230123032942.18263-1-gregory.price@memverge.com>
 <20230123032942.18263-4-gregory.price@memverge.com>
 <20230123154101.GA6268@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230123154101.GA6268@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SaBStsA41s3/laouuDYsr/GCYG9/ryGXPnWvKT2zNRktCSJneHUoqI+FohPP?=
 =?us-ascii?Q?V/5mRIHC5rxuW2hLvnWrV3xClDxhKxusVMmzBqU122jGF6teDyRHTn59yKdp?=
 =?us-ascii?Q?UK1XBVye1h43qRuqKn/9aHxOeb/0Unr7dpPT8LIddXCQxoLJtwkYyUBJz/6t?=
 =?us-ascii?Q?OgEvcaPpuNG+zdiqOeWGgavGJyH6pJTEj1ZHwQFvNXKdP50vT3O6X45ib5QP?=
 =?us-ascii?Q?Ux70GP9hs1TjizPH8/0olUyxIKTg1irq67GKeqJRNwBqhbz350qktx+gqBcV?=
 =?us-ascii?Q?+wierXbESt6wm5EKtgcMnx4yfIN3mja+9rLdbUDIVyoKX7zJ50owDdayNEFe?=
 =?us-ascii?Q?gzhnygJMCkPpr1UkXOTZLxtJfRQ106VO4v4WIBe9RQRSG3BH4G9I2iZsYvpP?=
 =?us-ascii?Q?30YPRndSh7klLO98qbrjfbLalkgjCIqmE7fZirlltfxPi3OyCSaVoeHLUw/4?=
 =?us-ascii?Q?D3YlZ+JRD4nqFxVX4Y2yhZYUOwsUeDeho4VgKAlranqest3s7SVvnddwUT23?=
 =?us-ascii?Q?syMuiejrOllwvIOPvNhrIbtEXNyJmd+/MicChF1evFysiF3cfxZMgJrpAgTs?=
 =?us-ascii?Q?6Wy/Wryffz2NI0v3Lz+8b3OH0GbR9Th2XNWTgTrdWJfnUYhO70dlUADoVY4I?=
 =?us-ascii?Q?XfPU7XSrhtm6fp/fiQcSof7spChn1HFPY72fUhNjKFRwuvuB95kfyBxPjkbH?=
 =?us-ascii?Q?cfFJu87ApkZ3FzKgk8yyUHZX0jjAfE94GksvHEf2yVTRjcErRe8/QOIubUmn?=
 =?us-ascii?Q?8Li2je+P6zG3/eLuMLufKGEQeNKgP63J5w2VNQ9ifdhBLDxxZAAbSWWgCwHq?=
 =?us-ascii?Q?rx6QGhIKL8VuVpGdDO5G8garZdhBYNIKX8s8Ai8WcgnrlIve5wwNx0TcSufv?=
 =?us-ascii?Q?nmqksDneOHcdlmhpDjUGlNnGe4dCXyvj7ir0ptojAhwobfW8wRYyeU9TNcsP?=
 =?us-ascii?Q?sDYoPmCYfNWCEdxIA06u1uAQPVBogfYWTqg4CXxcUvJDUHUD303S976vDrZ7?=
 =?us-ascii?Q?CZT10GBeMDKEGDYHnjjKMV2rA4V3r7xtvnl7MUU3jEACr0ASYjz+SHHqtwyx?=
 =?us-ascii?Q?wUP6LYR+3I9IQbj1e1v1cYyqpQT0Y5qU+1YtzDeXbcjjQoSL0xRxHtxU9nTP?=
 =?us-ascii?Q?LIqMS4AollFnDNIUzJi5EgqMfbU4npWFmYlQqhWX3fs440INz17Pa53WUfae?=
 =?us-ascii?Q?oiolgvPeAYSaSbbnThTagtysN7umkyQ/BKrbg/Or3LYKDEYLlbezmLmAcJX5?=
 =?us-ascii?Q?x4oGyrcxtfcstprh5ZixYgKqCT2vVG4LOWHC3lOK2yfhggcWIa9jP9JultxX?=
 =?us-ascii?Q?o83+M2L6uYIHrHY0Sc5Rco/X5qLHtWbWgX2dzRlARfg/egsXb1HPyBApJeGN?=
 =?us-ascii?Q?0voMoeR91raHkpBnW4gbQ+2bOoMsJt20ozYh8N87fLfdDlkrEwJ0YARil97d?=
 =?us-ascii?Q?3Y5sBIucyiK89c8qdzwZtsMWj6tvEGv0runwQ650DF0dFkKPiWiT4kFFjEjE?=
 =?us-ascii?Q?EO72pxtF8g/mh1CeDPX3dxEOhoUdnTLKm0+a80xiPJ86VSMQGV9kGu26W4BE?=
 =?us-ascii?Q?uhaIMAWowtlq15e3XfA1ZSAy7rI+wliG4oUa4bI7gHCLQvW+ZqwL/+t1uI+P?=
 =?us-ascii?Q?GQ=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e9271c4-6c06-4b96-ee10-08dafd6d695d
X-MS-Exchange-CrossTenant-AuthSource: BN6PR17MB3121.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 18:12:39.0966
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6Mm7bqF6L7R0zNC3FOEcmT+Dv57okheyF2bJkb+GXZaX7xA0PWK/2vkijH0lqiDUOS2TH0/u/eoWSC49JEvSDUBeItwsYP4xnPMqchpQTWw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR17MB6831
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 23, 2023 at 04:41:02PM +0100, Oleg Nesterov wrote:
> On 01/22, Gregory Price wrote:
> >
> > +int syscall_user_dispatch_get_config(struct task_struct *task, unsigned long size,
> > +		void __user *data)
> > +{
> > +	struct syscall_user_dispatch *sd = &task->syscall_dispatch;
> > +	struct syscall_user_dispatch_config config;
> > +
> > +	if (size != sizeof(struct syscall_user_dispatch_config))
> > +		return -EINVAL;
> > +
> > +	if (test_syscall_work(SYSCALL_USER_DISPATCH))
> > +		config.mode = PR_SYS_DISPATCH_ON;
> > +	else
> > +		config.mode = PR_SYS_DISPATCH_OFF;
> 
> Stupid question...
> 
> Why do we need 2/3 (which reports SYSCALL_USER_DISPATCH in proc/pid/status) then?
> 
> Oleg.
>

Actually a good question.

My original though was: CRIU uses proc/status to determine whether to
use seccomp dumping, so i may as well implement the same thing.

On further thought, I think you're right.  We can just always read and
set these settings regardless of the original state because SUD is not
seccomp.

1. if GENERIC_ENTRY is not compiled, and TIF_SYSCALL_USER_DISPATCH is
   not available, these settings get ignored anyway.
2. if disabled, offset/len/selector is guaranteed to be off
3. if you try to set something other than the above then this will fail
   anyway (see: set_syscall_user_dispatch)

ergo
4. It's always say to read/write these settings.  As with anything else
   you can certainly cause the user program to crash by setting garbage
	 but that's to be expected.


So i think dropping 2/3 in the list is good.  If you concur i'll do
that.