Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E76C25B50 for ; Mon, 23 Jan 2023 18:22:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233223AbjAWSWt (ORCPT ); Mon, 23 Jan 2023 13:22:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233343AbjAWSWm (ORCPT ); Mon, 23 Jan 2023 13:22:42 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9471C27D79; Mon, 23 Jan 2023 10:22:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uX1FU2QW6fhRi3bfPePvGfHUldz+VlZS/BdfnfTFzOM=; b=dL3pGez1eZOm5WrislEPELrwXD 3yYyounbJm8ddljIrjp7QHwwVkAxd9uMJo/y28OtvWTMK5F+IN+MrlmGSgDQnz0FnXunjWAo8032d LsusjrIHogjlXYoGyrTQT7cZNI/jlLVhVxMpuYTbOUuXMyiumgtFtTtaXd30zICvxTrHADeyQI1ti 6LhcjXrI5U0WmjKkw/8y8Zq9H+y9epSxAmsCqUaekt1dEN1TOS3oG+aLmUJEh7u/t8AKkI7F4F2F1 I2L8RtcrPEjkXxWPQ6ii+j4LOnXiIHbMdpwNMsmexEz9JGvHPbP+D2hCu5gRAINdE/Vp1UZwqKS5H 93x6wpVw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pK1Sb-00107A-La; Mon, 23 Jan 2023 18:22:25 +0000 Date: Mon, 23 Jan 2023 10:22:25 -0800 From: Christoph Hellwig To: David Howells Cc: Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v8 04/10] iomap: don't get an reference on ZERO_PAGE for direct I/O block zeroing Message-ID: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-5-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123173007.325544-5-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2023 at 05:30:01PM +0000, David Howells wrote: > From: Christoph Hellwig > > ZERO_PAGE can't go away, no need to hold an extra reference. > > Signed-off-by: Christoph Hellwig > Signed-off-by: David Howells I did originally attribute this to you as it's just extracted as an intermedia step from your patch. But I can live with it being credited to me if you want.