MIME-Version: 1.0
References: <20230116132152.405535-1-konrad.dybcio@linaro.org> <20230116132152.405535-10-konrad.dybcio@linaro.org>
In-Reply-To: <20230116132152.405535-10-konrad.dybcio@linaro.org>
From:   Arnaud Vrac <rawoul@gmail.com>
Date:   Mon, 23 Jan 2023 19:41:41 +0100
Message-ID: <CAN5H-g54j7kA0+7fmoyj+gOKENycOxJjpHiqbgfM_bYZXj2ofA@mail.gmail.com>
Subject: Re: [PATCH v3 9/9] interconnect: qcom: rpm: Don't use
 clk_get_optional for bus clocks anymore
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org, andersson@kernel.org,
        agross@kernel.org, krzysztof.kozlowski@linaro.org,
        marijn.suijten@somainline.org, bryan.odonoghue@linaro.org,
        Georgi Djakov <djakov@kernel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Konrad,

With this series on a db820c, I get an error on boot when probing
a0noc because no "bus" clock is defined. If I revert this patch it
works again.

-Arnaud

Le lun. 16 janv. 2023 =C3=A0 14:31, Konrad Dybcio
<konrad.dybcio@linaro.org> a =C3=A9crit :
>
> Commit dd42ec8ea5b9 ("interconnect: qcom: rpm: Use _optional func for pro=
vider clocks")
> relaxed the requirements around probing bus clocks. This was a decent
> solution for making sure MSM8996 would still boot with old DTs, but
> now that there's a proper fix in place that both old and new DTs
> will be happy about, revert back to the safer variant of the
> function.
>
> Fixes: dd42ec8ea5b9 ("interconnect: qcom: rpm: Use _optional func for pro=
vider clocks")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  drivers/interconnect/qcom/icc-rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/q=
com/icc-rpm.c
> index 343e6021a93a..8cff724661f2 100644
> --- a/drivers/interconnect/qcom/icc-rpm.c
> +++ b/drivers/interconnect/qcom/icc-rpm.c
> @@ -522,7 +522,7 @@ int qnoc_probe(struct platform_device *pdev)
>         }
>
>  regmap_done:
> -       ret =3D devm_clk_bulk_get_optional(dev, qp->num_bus_clks, qp->bus=
_clks);
> +       ret =3D devm_clk_bulk_get(dev, qp->num_bus_clks, qp->bus_clks);
>         if (ret)
>                 return ret;
>
> --
> 2.39.0
>