From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] scsi: qla2xxx: Use a variable for repeated mem_size
 computation
Thread-Topic: [PATCH] scsi: qla2xxx: Use a variable for repeated mem_size
 computation
Thread-Index: AQHZI6E2j5Qarh/OmkyGvGCGvWBPGq6sbWqA
Date:   Mon, 23 Jan 2023 18:41:54 +0000
Message-ID: <70C21723-6FC1-4590-8A37-A567E5C5D4E1@oracle.com>
References: <Y7spwF8HTt0c0l7y@ubun2204.myguest.virtualbox.org>
In-Reply-To: <Y7spwF8HTt0c0l7y@ubun2204.myguest.virtualbox.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JIPxC/g1MEYm8ylsXqri3gpXCPBvFiTGwHCUF/TeDWAdVe778L2i+OP+nhrF?=
 =?us-ascii?Q?KE6BdU66IZiqAsdd9YZpjfe3yFSYQwsi4FLmQFX8rNPRFC661ugNBQxSMGvM?=
 =?us-ascii?Q?lzgYNhA1NfHPpGgMKb3PPuM7iizd7DNDRzXZewx2eWrqVmkWCG/tu39mDf3P?=
 =?us-ascii?Q?ZR9wAx0uLfIgFp09+0RkXgEL6+IVSy9kn7RUYnd6l9iqkFavo+e0hGp9L3BI?=
 =?us-ascii?Q?hUCLvN1+8GOoaZPEo1sHhfAoJP8yyLNCLEYnS+ywwTEdQ8pkFaKyIZusaO27?=
 =?us-ascii?Q?vTIAyeDnFURbhtc4yK+ggi/KicPY7nzBX5KkzSv4yQoAFAmw18f+DAF98JN7?=
 =?us-ascii?Q?pZdsL+QJSUWlkp28w4f9MHHqRI+QBGURr4KQP8sdQYZs2oOksgy9Y8s2yWuc?=
 =?us-ascii?Q?INlDABK5czydBQAwYu32QBxMTo6dpxWISg69zYrCbTxfrRPAHA630BJm+Egj?=
 =?us-ascii?Q?Hs5B1M4h1kQ5BhWusobg8fbCuuKvoBh+nW1pzk7F7zdOzilzhxP7pbFfuMnt?=
 =?us-ascii?Q?gOu7vL9QPirhem8RG4qB7UtgeCFoY4A9zInNgIMXCMElJhrQDdnBhW3ilRFI?=
 =?us-ascii?Q?ozP7JDlPAS/Rk4Mzynz6cEbwT3hKqQqsZYAHamEqjACO9nz8PoUj15a0TMJ3?=
 =?us-ascii?Q?K8YNW4YfiRD6ZfKx7NfArPhnG19VwVsxxF0J+NGtEcj7UwvOV4zlxa3TNZW8?=
 =?us-ascii?Q?p6QolxKch/QTl34eSJArfsjEu9ihRdcsQugPByjTF90+jTZj45enHJ2TiF5n?=
 =?us-ascii?Q?Bi1xkb3SomEbGWh2uTSANS/zhS4j6/So4W2S+yxO/oH0PTbd3zIxw8KICJPp?=
 =?us-ascii?Q?hdyNYjP1vUqjXkpZuJu7YwsYjoXTIJaTRc4EzykXMRNIR2R84QpSpeMDlpsL?=
 =?us-ascii?Q?BdVoxbusCpqRvtDq2xSdyfXYCrpLW5u95p9VNw2kmMUWTrSpQRVshtnKZWaA?=
 =?us-ascii?Q?cBjs4rDgVQbtkh4U/M3plvD5SuWCnHbSLBX+aZF9AqgC4AhtW/H+chLyv/Qe?=
 =?us-ascii?Q?PrFWsVijBBV6cCJR0sneDVSbEGW9FndUstr3g0fhfNHbVioEBVjxbdVJjD+A?=
 =?us-ascii?Q?VXr9RSUwRoDZAMcM7SRElStHQJjM2QYZjFtr4R4tKJ3KA7sNCprW/YNxKSGi?=
 =?us-ascii?Q?nbcWAVuaSwo5zZXUGg/YB4BTiCpE3FwNQOyklqalSbOttTflUUJwyf5RjEgV?=
 =?us-ascii?Q?GCGur1fnDiz2ce3k5Fesejfr0cZVF2tS6N/8zvEJFIIrWc8Vgio/IigMf7p/?=
 =?us-ascii?Q?anG5mpTfEUL6MAI8f7dyEk9YjQbmnK1m3SDN8gWp3Bay5IcqZQt8N3G6edBs?=
 =?us-ascii?Q?H35u0afDF0Kq4MlVc07KF7fkHMVlwvT7zGl+bvw8G28ndHvNhiwpbkvAZ23i?=
 =?us-ascii?Q?B+G8/IDkZ7KwSR4XSn/8v+c2BFdRRQ1sPOuQ2kbiahR+9DhAxZFTs/Ycgi/g?=
 =?us-ascii?Q?Ex4oKvOuhkHGOJbGXSwo9KgmhI7nFBsOsRqk38RgPtpiqtshodEyMwCyio8J?=
 =?us-ascii?Q?tm1V7/Q17+GknKrumKLNn2cl+7goCiDZzJsJCH8HPLAD0qvRB9USv+P+Nmsq?=
 =?us-ascii?Q?BkTmBJefVlsO/1YbDMoLSHCMdfQSzbXj2rJmZX+pacLTv62ucfQBZioDZfFz?=
 =?us-ascii?Q?tGV/70NOawYxmnUq5QEfrj9CHrNYdfSD/zAmLiQjSEzg?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EBF36D47D9F19746BA38B511266A3454@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Ze6054yRHqIFRYe6EEtbk19l4MVxsiqiJDmMygtYReh61OYtVRpS6xSosIXb?=
 =?us-ascii?Q?0zR79gfD1Ge57ntXuwFLjUdIIdzrgjFRshfG+ru6iKLdb5wtBDVul4O4AYz0?=
 =?us-ascii?Q?oTAWs/1WC4XoM+1idI5e2xpVi4tuJ8Zmbiq2r5i7MN7/FqVZR8ubWJ/o+42h?=
 =?us-ascii?Q?pmorDz6Y63raetJ/37Bz+RrTZRN4qlAmkFwzzVG8hFgnEENO6d0MwQuml14a?=
 =?us-ascii?Q?CzX+4uMcw86IW7Qne4gcedykwNJfgrAr+xsSFcjkR152ijjtZ0DUbE6TROBt?=
 =?us-ascii?Q?Uz5dSH/KJR8OL/Fmukn+dlnXvnGYjj1rOOEmCr4FPkzpYFM3PbGVOIluMxE0?=
 =?us-ascii?Q?wJDDOM3dgT0+oLSPYhL0tmOF3yjkj3qVTkD1UHYGW8araoMRcdA3P58v5nSA?=
 =?us-ascii?Q?egCMDwW/2fVjSmgC34oy/pYXaiqf7XxnIsPL/Hl9N/teQr2TPrxS9PCZOhA8?=
 =?us-ascii?Q?RxCw8JSrgmL4LQYt5wv73lDFFisBjlFTD4ZESFB1CuQbxQhJURt2anzxxHuB?=
 =?us-ascii?Q?kK5+Hj+4idX3ru2mtTZrmx+tZ0gpC8s3v6nCM/QA8JQTFoYUEruCmZYm3aP5?=
 =?us-ascii?Q?m/ZzyBjnMACAjkDbMUbMzbvCUJcPOVrT0V2VZ+aNJHNt33gLqlnB+cb+f8Oc?=
 =?us-ascii?Q?wB37i2RLeTMhd04fYkYNV+gA6v4BeTJfaTSUJlVOLs6vHiht0OyPOMQdzww2?=
 =?us-ascii?Q?rZKR8jLMGSbVbh+BGZoIYC79UcICIuD9nb+yfcxG+eiY/G1jiq4lOUKcX+UO?=
 =?us-ascii?Q?btCNvsWOqeusiBEVu4Tov33gIM4WyfDqR2eXYjtZ2znTLTQAOEEwMzgxgDCO?=
 =?us-ascii?Q?SJTjfssCR0gZzdDLUWW7SPgL5dTCvGk+8cxQxiuVy+wn3DRrXbL8kouTTTZx?=
 =?us-ascii?Q?9exVrc//ZJohEnekPW5Vbrrz+AVhWfLEKjtFBCfaoZXDhEfAW+GkK1j0YzOx?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea249ec-a509-4825-6295-08dafd717fad
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2023 18:41:54.0922
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rmYCC86wLB3Iy3xAIaZrajL5x/Ol/XbtdrRbHb21i/hejkNfS5JNpsgkDa0FWT+d/DL0gSfbFGwQN3fIkreA7JezOQRspVnHM/n5pdTwI3I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6381
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-23_12,2023-01-23_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301230179
X-Proofpoint-GUID: GZwvKef5FP5mj6qI0tRa4qpl3kjW65L8
X-Proofpoint-ORIG-GUID: GZwvKef5FP5mj6qI0tRa4qpl3kjW65L8
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 8, 2023, at 12:38 PM, Deepak R Varma <drv@mailo.com> wrote:
>=20
> Use a variable to upfront compute memory size to be allocated, instead of
> repeatedly computing the memory size at different instructions. The reduc=
ed
> instruction length also allows to tidy up the code. Issue identified usin=
g
> the array_size_dup Coccinelle semantic patch.
>=20
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tc=
m_qla2xxx.c
> index 8fa0056b56dd..8024322c9c5a 100644
> --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
> @@ -1552,6 +1552,7 @@ static const struct qla_tgt_func_tmpl tcm_qla2xxx_t=
emplate =3D {
> static int tcm_qla2xxx_init_lport(struct tcm_qla2xxx_lport *lport)
> {
> int rc;
> + size_t map_sz;
>=20
> rc =3D btree_init32(&lport->lport_fcport_map);
> if (rc) {
> @@ -1559,17 +1560,15 @@ static int tcm_qla2xxx_init_lport(struct tcm_qla2=
xxx_lport *lport)
> return rc;
> }
>=20
> - lport->lport_loopid_map =3D
> - vzalloc(array_size(65536,
> -   sizeof(struct tcm_qla2xxx_fc_loopid)));
> + map_sz =3D array_size(65536, sizeof(struct tcm_qla2xxx_fc_loopid));
> +
> + lport->lport_loopid_map =3D vzalloc(map_sz);
> if (!lport->lport_loopid_map) {
> - pr_err("Unable to allocate lport->lport_loopid_map of %zu bytes\n",
> -    sizeof(struct tcm_qla2xxx_fc_loopid) * 65536);
> + pr_err("Unable to allocate lport->lport_loopid_map of %zu bytes\n", map=
_sz);
> btree_destroy32(&lport->lport_fcport_map);
> return -ENOMEM;
> }
> - pr_debug("qla2xxx: Allocated lport_loopid_map of %zu bytes\n",
> -       sizeof(struct tcm_qla2xxx_fc_loopid) * 65536);
> + pr_debug("qla2xxx: Allocated lport_loopid_map of %zu bytes\n", map_sz);
> return 0;
> }
>=20
> --=20
> 2.34.1
>=20
>=20
>=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com <mailto:himanshu=
.madhani@oracle.com>>

--=20
Himanshu Madhani Oracle Linux Engineering