From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH v2] scsi: qla2xxx: Simplify if condition evaluation
Thread-Topic: [PATCH v2] scsi: qla2xxx: Simplify if condition evaluation
Thread-Index: AQHZJk7oCAW9VyVo6EOC2oSgMeJ6Oa6scqAA
Date:   Mon, 23 Jan 2023 19:19:43 +0000
Message-ID: <520ACDB9-9DB3-4189-93B4-D1B0B0E76457@oracle.com>
References: <Y7+oJuah0MgEW0PQ@ubun2204.myguest.virtualbox.org>
In-Reply-To: <Y7+oJuah0MgEW0PQ@ubun2204.myguest.virtualbox.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KT3Y55Rbbr4UDyvqh50c6UmdmuKsO/HTvd/e2/Ie0Tb55AR3Y1z1RUKAhZZP?=
 =?us-ascii?Q?doezTm3zy496h5gw3V13no8H1JMXDL/aduiBwUhFaeZP06abSSFGMkvBdX7d?=
 =?us-ascii?Q?Sjg4MGIr3CzD94MLDLzC3718mOpvpYKGJJ4aHV1kfmyLJsBv4YhLrEEsnPX2?=
 =?us-ascii?Q?idlioEsE18ktRnyIX5bSGTvutL4ip5vfE30MyN6wsrpu1Bhk+LJe9Lcc6DXX?=
 =?us-ascii?Q?FtcaQ82SGguAePo2gerySF6221QqoQ2QWKQel/ovfAh2KLhkZRogaRu9AIDF?=
 =?us-ascii?Q?XTR1VCr7bOVZ/CaW1CQQhcfFa7lMc2+N8g9Ki7xkmwytKbABIVRrQ8lPKG+U?=
 =?us-ascii?Q?0/MGKVZBbZJz4Qs4wV/Oa+Am6UTseegxMXPc93gO1P0m186/BhJDwMc4AxzX?=
 =?us-ascii?Q?cdreCSYgjyJpRb/UIvvJe84B4/GPUt9c0oA4Q2Sn5gcVxbbfebOiBJ5i80Er?=
 =?us-ascii?Q?Y/otWWBQmyA3kVQUU004QgfTpZu8GDdr4detawgInSONVQF6tK6ACMTaazrv?=
 =?us-ascii?Q?gNX7DFJM/kYt/1Zq9qBVulvmKQ2gUZpy71szqwXFi8MuP1pJsF9VwA/sULiA?=
 =?us-ascii?Q?J4aJPgYRc7JI3wnHntL/Y8vUqR5vlvoYfvHfsSL5axtuqCh2f4mH+zDfw26t?=
 =?us-ascii?Q?esy0dawNi7Z+2824ZqpEm4NuC7ITPhVZ+GQfEufl31/DTTqdlIWwchay5LqZ?=
 =?us-ascii?Q?uuDVW52D2IEs7acxbu+h/kNZjnWj7h6p1N2xDWNXfkzN7sRG3xdAlZ08chym?=
 =?us-ascii?Q?NzmCrfnmdQ5pw1LnjHrUiHNXaCBHkTQkZdPatUE5kH4/Z+nDytkpNZVdcx5/?=
 =?us-ascii?Q?SkzF/5K0NJDP5xh/j417mpKaxYx/+Ppt5jxHIHU5nrRbmIm88LspaVavHhcY?=
 =?us-ascii?Q?yXyOKsb91+GazyuXJsBj0erlaD5ePV9rMfacATy1h3I/sGW/OjTeuWIvGI0E?=
 =?us-ascii?Q?P/IzQPIWdXXhZCnEpnkSL8Y38eeXYVQAeKlD/O9JyLp4yugafIEY3+iM5y4Z?=
 =?us-ascii?Q?8xZR4c0ZI8jcF2FrHXMG+sF9EYbkbGtmSdKk62xmxa2NDan/8vWnW9mdVWem?=
 =?us-ascii?Q?bA3I+T7fZfiYW+6IPJQ8Pxd4azpNeszqGOKCXFEGM4jnZ7cLP/5nOZCT3nVD?=
 =?us-ascii?Q?PAWovxuJtgHNj6qGjBvSROrgxslZ4IWkrPaJqLRu/7Svj0gVwYofZi8y7cd4?=
 =?us-ascii?Q?0K+rdtm+SRDQPLwTLsBvjGB9Ty+JFFzZGUnNYCeWzc4eUK3KtJ+5LTCRjoCU?=
 =?us-ascii?Q?O63vfPnnFP2SaEs23isiGOjNBEsXS4v2shoKIy5lrm2IujJCReVUL4oc/yf1?=
 =?us-ascii?Q?a7xqhjOzhpKT33DUIkDWnylzFSP0H8JKpvQ+cX+UTkrUBU5D4CmPSlxNqVCd?=
 =?us-ascii?Q?4yXfcClz+yjPTLgij7xILTklz/3prv8x54z7o9nG5FrIe/P7di8ZwjeYrdaa?=
 =?us-ascii?Q?67l1oLyJlDUnB+gf0HVK9cPQtAiWwYm6aMBdvJxsXNC5i81uVCWlPi4yv7Oo?=
 =?us-ascii?Q?J+ppvR491snkLHIiNcWZrMmFhNdxgjlJMF5iH5qZLC7NJ735B4EiZfPnCAtg?=
 =?us-ascii?Q?NcLbZYDeEHQGVADpg8Ozebk/Z+X2wdZZfJ9UD776xkOayAaq5ORWrWBcki8t?=
 =?us-ascii?Q?Jhs02+2vnbP7bx229VBOzuNFzoZVrb85O5CdHcYlZkJg?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5C110DD92DA1604D986C1E9A7E5FA593@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?7Co0iD+KSTKXN06VO5TBqddMzT6V5bnuuu+MkBWuQ2irJgFuevLdlYnbIBZJ?=
 =?us-ascii?Q?M98vA8GsV7eonuoaGz6paAOC1lg1QlAIGyKA0m7wrqKYBFSBJJtOlU54j5k1?=
 =?us-ascii?Q?FmaOb6SzskNxtgFIZKpfHic5ckmJsxo71w607STltjrnQBbSaqY9442ARWn0?=
 =?us-ascii?Q?hlakgUDiJz0Mc94Q8yiqhqgkl/ePO4NuqJrGe1IHKdGxvVuUImfG55kUOcXS?=
 =?us-ascii?Q?hhtcC9+2TRQD1AfCI0Jf+JU4q7J9AxGQve8QXnvNU0kUV90Ah1JFxFmYxoV5?=
 =?us-ascii?Q?hqGZnivlv4tZYC5jKfolL+XdeGznX5QGQ6Xi1VFJlG+yJ6ql3VRWB9Ra8DrL?=
 =?us-ascii?Q?KNkgPXTQGxu5hDbBwiNYLulmPly4D8EgAQWmHUgWWqcHj6IOqYlT1wBODqCw?=
 =?us-ascii?Q?NrlcwGX2GNz23MeKMD2K6KuZoOBIXE3DP4zgMV/UJ6nNTGoZa97fmXfrNaSc?=
 =?us-ascii?Q?8dJQWnAJv+UE7IaNxj9R7nDKFt7+TIQc66z3VWBFaiH9Zo+1WtZDyt7FpVAA?=
 =?us-ascii?Q?lAlm9/9pBZdTo4wagFI/76TvQPEIXH2qV+KYkyk+IDKUC/pSgTssEHPJBIhD?=
 =?us-ascii?Q?BVldMD3pA8AsnAd+Z6PN1sA/4Rz/Kjo63uu3VtXjKeQJDC99usW4UHPP6vvA?=
 =?us-ascii?Q?9MbkwihsNwxyUQwquK6LcUCZ8ZlDabjdbNoxGx3yMpq75OT/2+SQdOYFaJDe?=
 =?us-ascii?Q?rUf3HQSBIsID9Xjl6VDUE87miP9DyjQ56+mL00T0fYxSnxCKUD5E/V01m3a6?=
 =?us-ascii?Q?HqEha5FuK94JDRnGiHDKOtTnoNNRgiZfJM/ntEecj+xxn+1Ccuj6MOS/L2/+?=
 =?us-ascii?Q?uEQfoq0iGmnL1bdNopbRKQWS15RVpyrgAcUjQHmTJgGG8FJN7vfNNDZ9Vmz+?=
 =?us-ascii?Q?KNv9cT5Ln87ZsXdmdEk7gcQAZLJL+ZlB/ZZ/P2Taw9UPUSrDWem5t/ojTGRN?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6b1ccb2-1b59-4da4-145b-08dafd76c82e
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2023 19:19:43.2621
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UFGyz+6EucLHWe6CBY3Z9IoP5mUPmrU9B8z5IjaiwKwL+zUxbZRG0TQVSURu/8Uxtcw+/hMCCiWoyCMl3u0TVCFXi5rFhIIYAUVM/2fUfV8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6677
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-23_12,2023-01-23_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301230186
X-Proofpoint-GUID: woZv8OG5YEsq7VYSsBup5u4Mdshdpzkn
X-Proofpoint-ORIG-GUID: woZv8OG5YEsq7VYSsBup5u4Mdshdpzkn
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 11, 2023, at 10:26 PM, Deepak R Varma <drv@mailo.com> wrote:
>=20
> A logical evaluation of type (!A || A && B) can be simplified as
> (!A || B).
> Improvement by suggested by excluded_middle.cocci Coccinelel semantic
> patch.
>=20
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> Please note: Change is compile tested only.
>=20
> Changes in v2:
>   - Correct the if evaluation from (A && B) to (!A || B). Feedback
>     from Lee Duncan <lduncan@suse.com>
>=20
> drivers/scsi/qla2xxx/qla_target.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla=
_target.c
> index 548f22705ddc..4f104fbfe55d 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -1028,8 +1028,7 @@ void qlt_free_session_done(struct work_struct *work=
)
> }
>=20
> if (ha->flags.edif_enabled &&
> -    (!own || (own &&
> -      own->iocb.u.isp24.status_subcode =3D=3D ELS_PLOGI))) {
> + (!own || own->iocb.u.isp24.status_subcode =3D=3D ELS_PLOGI)) {
> sess->edif.authok =3D 0;
> if (!ha->flags.host_shutting_down) {
> ql_dbg(ql_dbg_edif, vha, 0x911e,
> --=20
> 2.34.1
>=20
>=20
>=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com <mailto:himanshu=
.madhani@oracle.com>>

--=20
Himanshu Madhani Oracle Linux Engineering