Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1C8C25B50 for ; Mon, 23 Jan 2023 20:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232927AbjAWUCd (ORCPT ); Mon, 23 Jan 2023 15:02:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232876AbjAWUC3 (ORCPT ); Mon, 23 Jan 2023 15:02:29 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E070230EBF; Mon, 23 Jan 2023 12:02:27 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0C5D340008; Mon, 23 Jan 2023 20:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674504146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K74/5wsg3+yOTxqONEVSXTGYGP5hKkIUuUVWXEdPX+U=; b=PVeZuonQyRMV8fUknilmMDX/TXRlPVFlCLaZ9sFKyaYVA0vxJRVcjQCZzFDW03toZaoJv2 lVXCH6v6vbIMT0+Vt39sQne8ZvD+91OFtAOuNIVEcFu2oOlNKcIXGvQidgQkaUtP3LKhrB izNJoZnH31fz94kFDGH78YRH36hOxpae70/QH/JXL1myrSNy3kIPI2ZXiEpJTVtJQAdABJ ZjnS/i3qbQ47bNLTBzVUY81LWKxaxMoba5N8Ek0CS1ILIGS8cQwxy4bI/xvaVTUq0OJ+uJ EzrzUnMslXbSKcJAECXMCV2+8kumXSZHkg3n7zPNlpDZNulmCf/guD7R/hxVWQ== From: alexandre.belloni@bootlin.com To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/12] rtc: hym8563: use IRQ flags obtained from fwnode Date: Mon, 23 Jan 2023 21:02:08 +0100 Message-Id: <20230123200217.1236011-3-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> References: <20230123200217.1236011-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexandre Belloni Allow the IRQ type to be passed from the device tree if available as there may be components changing the trigger type of the interrupt between the RTC and the IRQ controller. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-hym8563.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index cc710d682121..7d5a298a9a3b 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -518,9 +518,14 @@ static int hym8563_probe(struct i2c_client *client) } if (client->irq > 0) { + unsigned long irqflags = IRQF_TRIGGER_LOW; + + if (dev_fwnode(&client->dev)) + irqflags = 0; + ret = devm_request_threaded_irq(&client->dev, client->irq, NULL, hym8563_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, client->name, hym8563); if (ret < 0) { dev_err(&client->dev, "irq %d request failed, %d\n", -- 2.39.1