Date:   Mon, 23 Jan 2023 21:48:59 +0100
From:   Henning Schild <henning.schild@siemens.com>
To:     Lee Jones <lee@kernel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the
 GPIO providing driver
Message-ID: <20230123214859.725cd1c3@md1za8fc.ad001.siemens.net>
In-Reply-To: <Y8mv8PzL1UsP9gNh@google.com>
References: <20221007153323.1326-1-henning.schild@siemens.com>
        <Y8mv8PzL1UsP9gNh@google.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s2uUE1s4WG1dU1DQ03fLeSiPDGJy/kTYhzO/7bkpE2jZd0AQnyMFYWbZXTUe?=
 =?us-ascii?Q?hOGAdzj2JyV0lPRb2LVRLuJkjSEtSQHS2SQUxUtXXc4R7bUhZZJbVLCnoLyY?=
 =?us-ascii?Q?dofKoEfs+ALhbb0ucZX5z3woG5iWKhVwloXwWjOVXGtzpVQ7DPJ2miaC61As?=
 =?us-ascii?Q?q0pNyaDKqUg3vT93dQJcqGME6R9kHjAsAsOliNn5y++1NLpHcukXr2TijyA0?=
 =?us-ascii?Q?keb2gULvL2bNJXyg+y1IXnow5BtL6QnrTW8QSJw2xb47Kn4tRxWkM2mXG/zo?=
 =?us-ascii?Q?QtgrqXxy+do+pCaef3i2K1DeR95EaaoWPGUH6SBqcuw5IrDtCOVYLHsSHdUn?=
 =?us-ascii?Q?+S6kzxtkbdLqwzKoHR8wv0mZ32dyJkEFD/7w6hxQvOk/CEdTHMWQwNiZun00?=
 =?us-ascii?Q?YnwvKH4uosFOIv1u+lVCH1xQ2bJfyq08oyTbF1qQpbrhD49E3N9vwcUBd2Hf?=
 =?us-ascii?Q?Xo6vrBXvHkyIddO1zEiDa7Z8zowvxOn56WsR16YL/GnuxrQy6AsuKN0ch2Hk?=
 =?us-ascii?Q?vuRZmJdIBcA6soueQEV3OmYEnPIL8mJbvQuX59xS9osGx9e4k+syyITE1VZI?=
 =?us-ascii?Q?DHc3F7ubcsYN3bbW1jRMGb9emWIYp1Gz4uxhWy5e4drt8hS38AOYaksTRaSz?=
 =?us-ascii?Q?aawesco4/zYncGcGUx0XnIf3XSAxu7drwpEpEKN3/gIqVhLVYVkCzz0WzF5j?=
 =?us-ascii?Q?nXvA5NVVrvBhGVoEBJhj/KcAfbDPLx+4FZDRwl4fP7YwkDWi3LeT04FjsJUH?=
 =?us-ascii?Q?8OdytK1zlaCEjgBKP0HiaanBKl3iv6AgnqjmM036AVjaBMTwwSQlKo2Wv/Rd?=
 =?us-ascii?Q?GaRnHPV3dm3P1Y0KDDfldfrGj0PEb46zV9/S7vqmpst3Jfpl2MS4VmpaBwh5?=
 =?us-ascii?Q?dCTZDjkdN/fAvVO/DYG+rSzV/iH7lFexeiIntFMtqzcpiGBd5sIW5oXJ3CPS?=
 =?us-ascii?Q?D84VIxtp0oQn5LBaivg7GgwRuGQ3h5QEvnOxR4xx0711kyXpn/Ped0Ou54PR?=
 =?us-ascii?Q?fVGv0YrfJ5pX9rgO4hEpWq2RtgTRwfqo7TZat021nuV24AeIEfgM+92sMX+Q?=
 =?us-ascii?Q?xoHQjaAs4fcDMdjaLGrwWDE/ZBge26c7yx06TLzFVSgMijyDEm2ctAPnS8EK?=
 =?us-ascii?Q?1hM08OcRqRLHmcv6gCQ+y1VSlqpKa1/j3odzuiHdg1/6nSLcxRJ22q4ir5OH?=
 =?us-ascii?Q?KkM8e6oHx52wWHpMIWiXnxWu/EtiE7eqT/20Ota9HBXeJu89kVSc6khWNfnk?=
 =?us-ascii?Q?6OQ8Fmy+AoutxXtdTmDfO3iph6ueVyXPd4UU4Auj4AsGCFBJVqOlnTRVD7fE?=
 =?us-ascii?Q?Rd0NV0e+TlmUrRXuCsq6lGFsqCkU+mnVydCFcmftJ62Pa2ydojV7LmrRJ/ra?=
 =?us-ascii?Q?vwmYv4ojdikfnqRI4PUy/HHIdZEr/9sq20MuzCFdoq/rDPFfMuIJeTKUM9s5?=
 =?us-ascii?Q?E6lIYmp5soqZLSXLJSD4h3QYNjGydyVRdI1JjaZmW0PyDH+QNgS4buK5S5Mr?=
 =?us-ascii?Q?ud/R/5YyfkfGezD0Q3tMe6vctn9Vr3AwzLaC7XjZaEuOn1355xrAtDITt6Xk?=
 =?us-ascii?Q?P/nFaq0PXPRoVtgDqINYnDfXD+uPcJ4W3L9QaVr2TVrNvpZ+GCpbB5DbZO7b?=
 =?us-ascii?Q?QWtS6Sx9xyQWHZ7NCsBBmuX6sjd4spQ0Ey4JJA7IlggZ/E5wCBAGgnQz1Luy?=
 =?us-ascii?Q?M2m29w=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c08e897-0615-4dde-b0de-08dafd83447a
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 20:49:05.9030
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n+UBNCbri3abmlaHQWwvyufiWG+iem1oUuxYa2fmICkxA/YvrKK0Bof7/D1tZCZUN2hposkT7OFbIAZ1cyJRFvoqHONifCdgjd5/xfFIX5g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB5719
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Thu, 19 Jan 2023 21:02:40 +0000
schrieb Lee Jones <lee@kernel.org>:

> On Fri, 07 Oct 2022, Henning Schild wrote:
> 
> > If we register a "leds-gpio" platform device for GPIO pins that do
> > not exist we get a -EPROBE_DEFER and the probe will be tried again
> > later. If there is no driver to provide that pin we will poll
> > forever and also create a lot of log messages.
> > 
> > So check if that GPIO driver is configured, if so it will come up
> > eventually. If not, we exit our probe function early and do not even
> > bother registering the "leds-gpio". This method was chosen over
> > "Kconfig depends" since this way we can add support for more
> > devices and GPIO backends more easily without "depends":ing on all
> > GPIO backends.
> > 
> > Fixes: a6c80bec3c93 ("leds: simatic-ipc-leds-gpio: Add GPIO version
> > of Siemens driver") Reviewed-by: Andy Shevchenko
> > <andy.shevchenko@gmail.com> Signed-off-by: Henning Schild
> > <henning.schild@siemens.com> ---
> >  drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 ++
> >  1 file changed, 2 insertions(+)  
> 
> FYI: I'm going to try my best not to take another one like this.

understood!

> Please try to improve the whole situation for you next submission.

When i have to touch this again, which i will, i will propose either
"depend on all possible GPIO drivers" or introduce "#ifdef CONFIG"s.
Caring most about big configs as seen in distros like debian, even for
embedded systems ... i think i would prefer the first option, as it
will also be easier to maintain.

I do not see the whole infinite loop story on my plate, but if that got
fixed i would follow up taking the fix into account.

> Applied, thanks.

Thanks!

Henning

>