Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7526C54EAA for ; Mon, 23 Jan 2023 22:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233208AbjAWWpz (ORCPT ); Mon, 23 Jan 2023 17:45:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231789AbjAWWpx (ORCPT ); Mon, 23 Jan 2023 17:45:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D44612BF3E; Mon, 23 Jan 2023 14:45:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 89A2BB80EBB; Mon, 23 Jan 2023 22:45:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FF19C433EF; Mon, 23 Jan 2023 22:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674513950; bh=PFKvsUK0ALiS9A6m2M1DguOsRtNN0OwE/rRnm/K+Rxk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eS0pFPZ3B9YzJb2Y5w4hoeoCqwGRTmKNKMUjFTGsVUtjUY9jKVyz7KfBJP6RL/Ct/ x8k7tINpH7q6bBbB63hJvH1QePavTGtBiNg2wf9zRppGt1wZEGa0OePxzo5T+Akz4i qqOnjFYdmY37WsSXVb+86m4W7d8ThZLu+vvmoOOVOrSVjDmbd9CpgYHLKAle9HQvRg NpTBIqzmVgmYU12M4/Zo5nSNZUaHQpe0z6E4m1SmHUwcnujUDBMo72qrIo3lgiYr4l 5WwBjHLnJGuLDT/vZ4fgN4MB6u0/67XcrEtL8K9czQdldZv3EnJzkrW4UStkfTOqBp /hvbbTb+yJdhw== Date: Mon, 23 Jan 2023 14:45:48 -0800 From: Jakub Kicinski To: Maxim Mikityanskiy Cc: Hariprasad Kelam , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "davem@davemloft.net" , "pabeni@redhat.com" , "edumazet@google.com" , Sunil Kovvuri Goutham , Linu Cherian , Geethasowjanya Akula , Jerin Jacob Kollanukkaran , Subbaraya Sundeep Bhatta , "jhs@mojatatu.com" , "xiyou.wangcong@gmail.com" , "jiri@resnulli.us" , "saeedm@nvidia.com" , "richardcochran@gmail.com" , "tariqt@nvidia.com" , "linux-rdma@vger.kernel.org" , "hariprasad.netdev@gmail.com" , Naveen Mamindlapalli Subject: Re: [net-next Patch v2 4/5] octeontx2-pf: Add devlink support to configure TL1 RR_PRIO Message-ID: <20230123144548.4a2c06ae@kernel.org> In-Reply-To: References: <20230118105107.9516-1-hkelam@marvell.com> <20230118105107.9516-5-hkelam@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Jan 2023 22:05:58 +0200 Maxim Mikityanskiy wrote: > OK, I seem to get it now, thanks for the explanation! > > How do you set the priority for HTB, though? You mentioned this command > to set priority of unclassified traffic: > > devlink -p dev param set pci/0002:04:00.0 name tl1_rr_prio value 6 \ > cmode runtime > > But what is the command to change priority for HTB? > > What bothers me about using devlink to configure HTB priority is: > > 1. Software HTB implementation doesn't have this functionality, and it > always prioritizes unclassified traffic. As far as I understand, the > rule for tc stuff is that all features must have a reference > implementation in software. > > 2. Adding a flag (prefer unclassified vs prefer classified) to HTB > itself may be not straightforward, because your devlink command has a > second purpose of setting priorities between PFs/VFs, and it may > conflict with the HTB flag. If there is a two-stage hierarchy the lower level should be controlled by devlink-rate, no?