Date:   Tue, 24 Jan 2023 08:06:00 +0700
From:   Ammar Faizi <ammarfaizi2@gnuweeb.org>
To:     "Paul E. McKenney" <paulmck@kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Willy Tarreau <w@1wt.eu>, Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH RFC] tools/nolibc: Add gitignore to avoid git complaints
 about sysroot
Message-ID: <Y88u+KnrxjrC+NBe@biznet-home.integral.gnuweeb.org>
References: <20230124004707.GA318943@paulmck-ThinkPad-P17-Gen-1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230124004707.GA318943@paulmck-ThinkPad-P17-Gen-1>
Precedence: bulk

On Mon, Jan 23, 2023 at 04:47:07PM -0800, Paul E. McKenney wrote:
> Testing of nolibc can produce a tools/include/nolibc/sysroot file, which
> is not known to git.  Because it is automatically generated, there is no
> reason for it to be known to git.  Therefore, add a .gitignore to remove
> it from git's field of view.

Yeah, I hit the same "git status" complaint and have a pending patch
for that too:

https://github.com/ammarfaizi2/linux-block/commit/89bfe86a03c173863de12.patch

^ I'll drop this one.

> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Willy Tarreau <w@1wt.eu>
> Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> 
> diff --git a/tools/include/nolibc/.gitignore b/tools/include/nolibc/.gitignore
> new file mode 100644
> index 0000000000000..dea22eaaed2ba
> --- /dev/null
> +++ b/tools/include/nolibc/.gitignore
> @@ -0,0 +1 @@
> +sysroot

Small nit about the naming, not so much important, but the common
pattern for directory has a trailing slash. So, I would write
"sysroot/".

".gitignore" and "tools/testing/selftests/.gitignore" do that too :-)

Reviewed-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Thanks!

-- 
Ammar Faizi