Date:   Tue, 24 Jan 2023 11:09:41 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Stefan Roesch <shr@devkernel.io>, linux-mm@kvack.org
Cc:     linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org
Subject: Re: [RESEND RFC PATCH v1 15/20] docs: document new procfs ksm knobs
Message-ID: <Y89aBXuPrbjrFAmC@debian.me>
References: <20230123173748.1734238-1-shr@devkernel.io>
 <20230123173748.1734238-16-shr@devkernel.io>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="XX6agEIUzIpHNuNV"
Content-Disposition: inline
In-Reply-To: <20230123173748.1734238-16-shr@devkernel.io>
Precedence: bulk


--XX6agEIUzIpHNuNV
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 23, 2023 at 09:37:43AM -0800, Stefan Roesch wrote:
> This documents the ksm_process_profit and ksm_merge_type settings in
> ksm_stat.

"Document both ksm_process_profit and ksm_merge_type proc settings."

>=20
> Signed-off-by: Stefan Roesch <shr@devkernel.io>
> ---
>  Documentation/admin-guide/mm/ksm.rst | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-g=
uide/mm/ksm.rst
> index 72189bf1283e..70896f01d641 100644
> --- a/Documentation/admin-guide/mm/ksm.rst
> +++ b/Documentation/admin-guide/mm/ksm.rst
> @@ -211,7 +211,8 @@ several times, which are unprofitable memory consumed.
>  			  ksm_rmap_items * sizeof(rmap_item).
> =20
>     where ksm_merging_pages is shown under the directory ``/proc/<pid>/``,
> -   and ksm_rmap_items is shown in ``/proc/<pid>/ksm_stat``.
> +   and ksm_rmap_items is shown in ``/proc/<pid>/ksm_stat``. The process =
profit
> +   is also shown in ``/proc/<pid>/ksm_stat`` as ksm_process_profit.
> =20
>  From the perspective of application, a high ratio of ``ksm_rmap_items`` =
to
>  ``ksm_merging_pages`` means a bad madvise-applied policy, so developers =
or
> @@ -222,6 +223,9 @@ so if the ``ksm_rmap_items/ksm_merging_pages`` ratio =
exceeds 64 on 64-bit CPU
>  or exceeds 128 on 32-bit CPU, then the app's madvise policy should be dr=
opped,
>  because the ksm profit is approximately zero or negative.
> =20
> +The ksm_merge_type in ``/proc/<pid>/ksm_stat`` shows the merge type of t=
he
> +process. Valid values are ``none``, ``madvise`` and ``process``.
> +
>  Monitoring KSM events
>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =20

The change LGTM.

--=20
An old man doll... just what I always wanted! - Clara

--XX6agEIUzIpHNuNV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY89aBQAKCRD2uYlJVVFO
o5VVAQDUTWIM8oin7v2bLz8Fg+xjQgz6v0OLJxT0G5Q0oiQeuAEAtVt3/yWMls24
CeYG0s/x1NbG/nXXj/D9+N7HeZvVSwY=
=O4Jm
-----END PGP SIGNATURE-----

--XX6agEIUzIpHNuNV--