Date:   Tue, 24 Jan 2023 07:18:46 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     Brent Pappas <bpappas@pappasbrent.com>, slongerbeam@gmail.com,
        festevam@gmail.com, p.zabel@pengutronix.de,
        gregkh@linuxfoundation.org, s.hauer@pengutronix.de,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com, kernel@pengutronix.de, mchehab@kernel.org,
        shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-media@vger.kernel.org
Subject: Re: [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled()
 with function
Message-ID: <Y89cJvIYtg9fkczb@kadam>
References: <20230123191714.22430-1-bpappas@pappasbrent.com>
 <20230123215105.fbfzxueegtnbu4ym@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230123215105.fbfzxueegtnbu4ym@pengutronix.de>
Precedence: bulk

On Mon, Jan 23, 2023 at 10:51:05PM +0100, Marco Felsch wrote:
> > -#define icap_enabled(fim) ((fim)->icap_flags != IRQ_TYPE_NONE)
> > +static bool icap_enabled(struct imx_media_fim *fim)
> > +{
> > +	return fim->icap_flags != IRQ_TYPE_NONE;
> > +}
> 
> Nit: I would make it inline but recent compiler may do the job for us.
> 

Yeah.  These days we tend to not make things inline.

regards,
dan carpenter

> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> 
> Regards,
>   Marco