Date:   Mon, 23 Jan 2023 22:30:33 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Eric Dumazet <edumazet@google.com>
Cc:     Vladimir Oltean <vladimir.oltean@nxp.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Kubecek <mkubecek@suse.cz>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Rui Sousa <rui.sousa@nxp.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v4 net-next 04/12] net: ethtool: netlink: retrieve stats
 from multiple sources (eMAC, pMAC)
Message-ID: <20230123223033.3ad37ccc@kernel.org>
In-Reply-To: <CANn89i+-Vp3Za=T8kgU6o_RuQHoT7sC=-i_EZCHcsUoJKqeG9g@mail.gmail.com>
References: <20230119122705.73054-1-vladimir.oltean@nxp.com>
        <20230119122705.73054-5-vladimir.oltean@nxp.com>
        <CANn89i+-Vp3Za=T8kgU6o_RuQHoT7sC=-i_EZCHcsUoJKqeG9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 24 Jan 2023 07:20:20 +0100 Eric Dumazet wrote:
> >  static int pause_prepare_data(const struct ethnl_req_info *req_base,
> >                               struct ethnl_reply_data *reply_base,
> >                               struct genl_info *info)
> >  {
> > +       const struct pause_req_info *req_info = PAUSE_REQINFO(req_base);
> >         struct pause_reply_data *data = PAUSE_REPDATA(reply_base);
> > +       enum ethtool_mac_stats_src src = req_info->src;
> > +       struct netlink_ext_ack *extack = info->extack;  
> 
> info can be NULL when called from ethnl_default_dump_one()

Second time in a month, I think..

Should we make a fake info to pass here? (until someone finds the time 
to combine the do/dump infos more thoroughly, at least)