Message-ID: <f2a2ec3a-d4ef-985c-2324-736fb863575a@nvidia.com>
Date:   Mon, 23 Jan 2023 23:03:20 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v8 04/10] iomap: don't get an reference on ZERO_PAGE for
 direct I/O block zeroing
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>
Cc:     David Howells <dhowells@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Jeff Layton <jlayton@kernel.org>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
References: <20230123173007.325544-1-dhowells@redhat.com>
 <20230123173007.325544-5-dhowells@redhat.com>
 <eb1f8849-f0d8-9d3d-d80d-7fe8487a15f4@nvidia.com>
 <Y89zypNE5z7rgdtX@infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <Y89zypNE5z7rgdtX@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVJXS1Jnd0I1MFNBOXljSngwKzZHby9nR2hRNDlhQUxLVG9GWG5OLzRKaEJq?=
 =?utf-8?B?WS83dUNlYzI1bFlKWDNrbTVCMDZiWE9BOU5ubVJOZVUxUTdYVzBXblF2TkRj?=
 =?utf-8?B?L3d1a1l2NC9kNVk5YnUxVmwzZmNhOWdaZ0w5OUpVcjNPMGthNUpGdDNFbFVW?=
 =?utf-8?B?dy84Q29YdWppTVRxemozTEp6VkloaEhYV2ZDY3FPNlFuNUI0bFU3MnF3U291?=
 =?utf-8?B?RnRjeWNpS0c3YzJ1ZERUYjN0NFRrNmhYY2NONWIxZUxkTS8wNzBWWnQyeU1C?=
 =?utf-8?B?L081NnJ6MzBVQVJVTFBHS2ZjZGVHNlJmakRoOGZXU25NZDJScGxWQzJJVlV5?=
 =?utf-8?B?NW15b0I3RGpZU3RVMURPOVhYTGhGa1hVV3lFaDZLOURRV3ZnRVJyWU1vb09U?=
 =?utf-8?B?NG9zUVY3T1ZjL3hVaFdpeGU4T014aEpjR0I5RWxub2taSmRTTmlHSVZpeVg3?=
 =?utf-8?B?S1JZOUY4THF6U1ArNmNZajBNa25xSDlQQm52KzNKbkhpbmNGeDNmMHhkaGZP?=
 =?utf-8?B?dTAvWUJUTjZIU09lMmZnM2lWaFpZamhtMkpIMXdlUkJGc0wwRlFZREpvcEpp?=
 =?utf-8?B?QUs2ajdoc1hLQkh3cUdkTTllVEJabXZMQ0RFb2FiR2U2QWE5VG50MWloQ1M4?=
 =?utf-8?B?eWRLTkE4UU5mcnZwbGhHRjZvWjZLRXVPZGtEUzB5MUk0VTVBL28zaWQ4M1Jj?=
 =?utf-8?B?eThTczk1clJqeXJjR3JnWHo5S3dTNTZXMURJYUZESlRDSVhjcFpRcTA4cTF2?=
 =?utf-8?B?a1BoMURnZU9JaTNPTTgwTktRT1NpWnMycStPQmhvNmdxUWtpbVFuM0dHQmpq?=
 =?utf-8?B?OVNnS1F5ekFJZlQ4WHVkTmZxM0VvZUdmZWVMK0xGTnZ3N3liN0VwVGtTV2Jl?=
 =?utf-8?B?eVA3Z0E4bW1DUjZ0S2lzdjlCaytaQzJCSEF2OUlwUXJDV3ptWUFoeGc1MkhU?=
 =?utf-8?B?ODdHd2htVFJkd0ZUUDRnMmFtVllKeEY2R1QvM3d6RjhNcXErWFRxS2NoL2lT?=
 =?utf-8?B?enVRbUZESStCY0RxR1dEeWFJdEpQRTk0aWdKd2FFMWZkaTkvUmZYd0d6RDNW?=
 =?utf-8?B?aXdtOERES3JnVGFQek5GMEZzVFdSY0NRREtNUHY4OFFNVVpYSnBVbk9lTFBL?=
 =?utf-8?B?SkErMXBNczVIaU5KWW1XT3FoNk4rWDR5MGpTWXkzVDlBTE1XckMzMVNnOVlE?=
 =?utf-8?B?Rk0vaXhXcFdmNmRySXYxd21MZ0F2QkNBMFhaeklWSnJnaStsZU9ndnovbVFB?=
 =?utf-8?B?UjdOMFcxRURBODA2eDc4ZjU0aEp0K3RVZ3NzT3QwakpRYWJQK3lxTWlUS0hU?=
 =?utf-8?B?UE5jakMrZG5PYnhJSGZMTyt1QmJQbTZqcTBwc2xqV29KcUZ2M0JpSW1WZGxj?=
 =?utf-8?B?ME5QTVdabUhqVjV0OHRvWXoreUpTczR0QU5wOEc0TURNVWdsc0JKd05tMjNN?=
 =?utf-8?B?MVJOMGU3Z0FSV0l5cjVpMXFQUDk0ZXhvWHB6dUoxOExUQytVWTZ2TDZpZkVk?=
 =?utf-8?B?TExaZktiZjB6c01ia1Q1aFBDZDBjSnZmNVkyTlNKUUhrSzBia1pENWZiSmRO?=
 =?utf-8?B?OEw3R0MybFE1Z0U3ZlQxY3ptaVdhbGJWakxTSjNDbmZmd2VaYmZWV090V1BR?=
 =?utf-8?B?d0JGTzU0aURVVEpjUGFUSTh1UlZyU0NDWFVwY2pTQVNKS3hXWm4rcUl6QnQ1?=
 =?utf-8?B?b3VSdCtoTU5YUllWcDF6WUh4d1RnUHRQeDd0eUFjcVJJcVpvV25oREJBd0VZ?=
 =?utf-8?B?dlM2ckYvdVNIQ0VIRlgzd1dpcGp3VzNsa3hPTmxGNTMzcktxRFlFNFJNMnAy?=
 =?utf-8?B?ZDZjRUhveFU1VGI1R214YWRjeHdQOXBXUjBhaGU5K29IOWE3R09OZ3dRZEIw?=
 =?utf-8?B?a094NjNraFZqanNVRGMrWmhuLzd3Qlh5QnhSYWk2aFFpWjNLamhoRGR5aUhy?=
 =?utf-8?B?ZFg0UC9MMXpSSGN6UmFmRGZ0SGxORW5YZitSMlRnQjlTR0I5ZUpFOUpTK0NT?=
 =?utf-8?B?SkpZT0tGc1NmS1dObEJjdWVwRVd0bGErVkRCdE5EcGkrV0JiWEh2dlN2OE51?=
 =?utf-8?B?MytnUHUzbDFITEc4Y3A3enBiYUNvQWFHRUhTbkswMWZXbjdXWVpMMk5YTzBB?=
 =?utf-8?Q?e2w62qaysd85Kxndr2u2DJvcH?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b4f1a7e-af44-4bc7-5666-08dafdd91494
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 07:03:22.2905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O2rYu9qzk3mpNZOKXFAat5ijSjhTWqZK1HjW/SfKtWoFluAM64sE7Hvy4YGK+stsAyHh1g/wZxetv9Kw6sp/Ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7568
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/23/23 21:59, Christoph Hellwig wrote:
> On Mon, Jan 23, 2023 at 06:42:28PM -0800, John Hubbard wrote:
>>> @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio,
>>>   	bio->bi_private = dio;
>>>   	bio->bi_end_io = iomap_dio_bio_end_io;
>>> -	get_page(page);
>>> +	bio_set_flag(bio, BIO_NO_PAGE_REF);
>>
>> ...is it accurate to assume that the entire bio is pointing to the zero
>> page? I recall working through this area earlier last year, and ended up
>> just letting the zero page get pinned, and then unpinning upon release,
>> which is harmless.
> 
> Yes, the bio is built 4 lines above what is quoted here, and submitted
> right after it.  It only contains the ZERO_PAGE.

OK, yes. All good, then.

thanks,
-- 
John Hubbard
NVIDIA