Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763809AbXH1T0x (ORCPT ); Tue, 28 Aug 2007 15:26:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761674AbXH1TLT (ORCPT ); Tue, 28 Aug 2007 15:11:19 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:36779 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761653AbXH1TLS (ORCPT ); Tue, 28 Aug 2007 15:11:18 -0400 Date: Tue, 28 Aug 2007 20:11:14 +0100 From: Christoph Hellwig To: Jeff Layton Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org, nfs@lists.sourceforge.net Subject: Re: [PATCH 0/4] add killattr inode operation to allow filesystems to interpret ATTR_KILL_S*ID bits Message-ID: <20070828191114.GA3419@infradead.org> Mail-Followup-To: Christoph Hellwig , Jeff Layton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org, nfs@lists.sourceforge.net References: <200708271727.l7RHR36m007248@dantu.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708271727.l7RHR36m007248@dantu.rdu.redhat.com> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 27 Sorry for not replying to the previsious revisions, but I've been out for on vacation. I can't say I like this version. Now we've got callouts at two rather close levels which is not very nice from the interface POV. Maybe preference is for the first scheme where we simply move interpreation of the ATTR_KILL_SUID/ATTR_KILL_SGID into the setattr routine and provide a nice helper for the normal filesystem to use. If people are really concerned about adding two lines of code to the handfull of setattr operation there's a variant of this scheme that can avoid it: - notify_change is modified to not clear the ATTR_KILL_SUID/ATTR_KILL_SGID but update ia_mode and the ia_valid flag to include ATTR_MODE. - disk filesystems stay unchanged and never look at ATTR_KILL_SUID/ATTR_KILL_SGID, but nfs can check for it and ignore the ATTR_MODE flags and ia_valid in this case and do the right thing on the server side. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/