Message-ID: <6dffbda3-2611-2b4e-3ccd-7307b015991e@axis.com>
Date:   Tue, 24 Jan 2023 09:46:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 4/4] ASoC: dt-bindings: ti,ts3a227e.yaml: add jack-type
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>, Astrid Rost <astrid.rost@axis.com>
CC:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Dylan Reid <dgreid@chromium.org>, <kernel@axis.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
References: <20230120102555.1523394-1-astrid.rost@axis.com>
 <20230120102555.1523394-5-astrid.rost@axis.com>
 <20230123220928.GA2720169-robh@kernel.org>
From:   Astrid Rost <astridr@axis.com>
In-Reply-To: <20230123220928.GA2720169-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGNjK1VkU3dMMGR5S2JoYWdmRysvYVJUQklVYy9KUjNrVFdxdmVSOURnMUw5?=
 =?utf-8?B?TEJ6MWZwOEtsdEc4TkFwWFBONzJnWXVyaGt1Mm1lZmFUT0c5dkNsN0pCL1pP?=
 =?utf-8?B?WTErQnp0WE5YUkQ3ZWh2Ymd6cDdPSnJ5cFBCRytvSlZyelprSm9ramNLRVBq?=
 =?utf-8?B?VTlwU2lnUDJCa1grSDhpR1V1QWZ2aTFZaDlLdTVYNmJGQ1VhbFpHZkNMTkJj?=
 =?utf-8?B?blBDeGl1ZnFlQnVoNmxOd0tDdXhDUWJLUndubmdWMGtZNWpEMUZLQnNlbTVJ?=
 =?utf-8?B?c1BRZXdOSUZTUjBNek51WlV4TXovYTkwaDRvRmhkNXF6TFJHZHhlMFdJNG1U?=
 =?utf-8?B?dWw2TVorVC9XYmJzZzhtdUlNczZKRk1iWkp2Qy9mMEw0NHRwWlUvL1Uxa0tp?=
 =?utf-8?B?RS83ZlJ3UUhPL3hCRHAyTThDVjROTlQ2UkM0aTNUckFCeU02ZVVuL0lwa01x?=
 =?utf-8?B?NTNJNTVIZm0rb1NlUXNRak9TQXJvV3JUSWx3RHlpMUY3T29OMWZJNTJRRHRT?=
 =?utf-8?B?bHp5WUFnemJjRlVOZzRZODJJdWdUM3VuMEZBeHMvOUJtVlorcU1CMHRPMnA2?=
 =?utf-8?B?WUVtU01zcDBtdFFMZ05OcElNajdXWUlGSExNVCtjbnhiQm1EcEMyVUlTaTJs?=
 =?utf-8?B?OWIvU1JRRVFnQVpac3FQNjdybG1veDBUTm54T1NLRG1NenFhY0FjazJFQXRL?=
 =?utf-8?B?d0hwQUxiSVNTbVhuUGxnQU5oUEFlaW1YR2picHNPL0hBTXovMENQRWU1TkU0?=
 =?utf-8?B?SXNRc2hpbkpFZjRKZFprekNDVEdVWXBQNjBlYXN1ZFVqbDVQQjMwOGgvNVJ4?=
 =?utf-8?B?RXF4cGZWRWs5Y3lIMEZrZ2VWRlRLMjU4T0JlNkJIK1Vqai9VYTlZMzNNdThk?=
 =?utf-8?B?N1k2dzdMdnUvNVBwbWdLRlJhZzQ1a0owUWNTQjdtdk5hME1LN09rQ1hLT2Jj?=
 =?utf-8?B?aHVERmE2M2RjYlgyQkcvRXg3OXNXZGR2cERRbzZNUHZiT2pMRlRCWXNxTHcx?=
 =?utf-8?B?U2JhWFA3L1dkdnViK3RJY0gxajNNVkZpU2s4SEJYSytEZ05EMXRmWDlOWHlP?=
 =?utf-8?B?R3owMlE2VmV6VXNZT084alR5ZDNYeDFvQ2hnUzNwSUliNHBqQ2YrZmhoTmcx?=
 =?utf-8?B?cHRjeTJydWJFSkVIRW95d1dZTU8rdS96dUVnN3hEUEg1WU5ZeWNLdEpFQkdP?=
 =?utf-8?B?YmZmTkFzbzUwY0Y0WmY3U0hCUzhYZkpsZjAwb2p6RGVmZUtFZ0c3OGk2SFF0?=
 =?utf-8?B?NGlzS2tPbEdsdU13ZnA1Lzd1OTNiRTlZcVJCNG44NWpuS2w2TE9VMXpIZ3l2?=
 =?utf-8?B?b1MraHFmZDZHcUR2YVJ4RnA5RTRpOHl4RksxSUZ4MCtETmxlT3BoOW1MRU1V?=
 =?utf-8?B?Y2hlYU5PeWxvamtBcWE4YU8yc1NwdFRJcC9abWZURFBTYTk3UCtsL05nWlVU?=
 =?utf-8?B?eWpaNXNtbkRjZEsyblRBSGRTMTFNTmFUa2VjSjRtc1NJREJNcXkreXJDakEz?=
 =?utf-8?B?c0loWjd0MFBmWWg1Lys0elRScXh1aVI1cDRySENXS1IrWTBLREI3R2RuOXpp?=
 =?utf-8?B?ZmUvdlIxNlFmRmpsL0JLWUJ5aVRKRnBHeHZicTNUWDduRlhUNnNORDRiRmZr?=
 =?utf-8?B?R1MxdTkwbi9BaGlxSFFOMGR3ak8rdWpsVXhHOHlqVytmUVd2U2hzN0thNENn?=
 =?utf-8?B?djd0OWw5Q013ME5sYTg2eHF5ODFMOUhZS0ZIM0wyQ2hKWHgyZlJIS1Zla1JW?=
 =?utf-8?B?aVMvYXorQWZoREJOZVNjNDNZNjRwK2FmS0dFZ0VTazY2MXNITmlEQW5oSXV2?=
 =?utf-8?B?azVqRnhYVDI4MFlwd2JWMVFVeTVnRTg3WW5FRnVnQkViVFduc094S1dNYlZ2?=
 =?utf-8?B?aGw3T0pBU0VmTUNKem1jMnRITllxbjM5ejJ2d0Q4c1lsRjdVZkhWTnpvNGlY?=
 =?utf-8?B?ZmNDMXRIZzN1TThvMElwY0RMUEFRNDNRRC9tbHB3WW13ZHVIbzFkS1Fxa2tm?=
 =?utf-8?B?RXYxZEJMK1EyMkUrVkJiYjJEL0RQaUdjbFBaajlLdHd2SFF4QTNiM0l0Ujl0?=
 =?utf-8?B?M1BnTVNlWDFVNU1GRVJqMmNpbDJUVDNnZytnY3ZzRDF2R3hzZFJhTFl1dmMz?=
 =?utf-8?Q?d4UXsv0vU6wJR3jQUR3BrJPfO?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 34a75cc2-e0ee-4758-424c-08dafde76d49
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB9467.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 08:46:04.0386
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AMCw+xZg5mlLOCjZTDpEJVG+MMJkYQ7iB3mi4hXESh0ueY4TqvAcbKPJa71si4UpN+3OxWgx13S93319O44Idg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB6566
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Rob,

On 1/23/23 23:09, Rob Herring wrote:
> On Fri, Jan 20, 2023 at 11:25:54AM +0100, Astrid Rost wrote:
>> Add jack-type: Bitmap value of snd_jack_type to allow combining
>> card drivers to create a jack for it.
>>
>> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
>> ---
>>   Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
>> index 785930658029..1d949b805f98 100644
>> --- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
>> +++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
>> @@ -27,6 +27,14 @@ properties:
>>     interrupts:
>>       maxItems: 1
>>   
>> +  jack-type:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: Bitmap value of snd_jack_type to allow combining
> 
> snd_jack_type? Is that a Linux thing? Bindings are independent of Linux.
> 
>> +      card drivers to create a jack for it. Supported is
>> +        1 SND_JACK_HEADPHONE
>> +        2 SND_JACK_MICROPHONE
>> +    default: 3
> 
> I'm pretty sure jack properties are more complicated than just headphone
> and/or microphone. There's buttons which are detected in differing ways.

Yes, you are right. On the buttons, someone would like to have an 
keymapping like KEY_VOLUMEDOWN, KEY_VOLUMEUP for the different buttons 
SND_JACK_BTN_X. This is always added to the jack by the ts3a227e driver.

I pushed yesterday a v3, which returns all supported jack types by this 
device. I am happy with this.

> 
> Rob

Best regards

Astrid