Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70356C25B4E for ; Tue, 24 Jan 2023 10:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233453AbjAXKwL (ORCPT ); Tue, 24 Jan 2023 05:52:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233482AbjAXKwJ (ORCPT ); Tue, 24 Jan 2023 05:52:09 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BF6044B1 for ; Tue, 24 Jan 2023 02:52:07 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id g16so1376923ilr.1 for ; Tue, 24 Jan 2023 02:52:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PZZkl0nuhDOnpS6mpTFr8PbXxlSJ2XVVn7nhNW4knVE=; b=eysX+ECnIsH4FMjfUYT/LQAt9n6rglG6tqxiFcoAUICMiQfGdw6uRCYzxropjiIHWX aGm0Ai3CVpIR3vF+EduIDOySpa/9Cs7/A0TdpklPuDWKFUgQZpGb/QUx7y/gmG1+gJQT R0EgI2WlD8RTdP4mKPBp2BIR3O5cm0XeN7nPZ0SG8//AUcx383pwBNqlJlupg5yLuFLh /Bt4ywpI6JPeuzM6XnPuB0hUMriFJgSFDg1wnWsB4yXnlV+fcImKNZFnp8e56Zo2rLxF LM6SKfI/YCy26+jyb1ULwBcIRsTXvzHOZMkpI89Kjz5MQ29Qw33zMIR8Bf4V25RxB/nC pH4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PZZkl0nuhDOnpS6mpTFr8PbXxlSJ2XVVn7nhNW4knVE=; b=EB2KraxfnYRCqaDowJI4ZNFx4mEYeLfLXRjfuQLamp9PGWAZuDKx6Xsv3UXKXytVZ+ u9uhN2R6qYdrnUvlIIuUjA7FNzHSlJTUUSXP8I+bzPPVHWRp2l2lTM+bU8MDlXxpG1K7 o+K8RWYpXuO5jvwjniuG91MEJPXCNdiO6J2YRs2nppvNOLA0Jbsi60DHAbKFDWlhq/f7 Ywap2z3Dg0RxrGiWjacdAm+JEQqHZ3TKgB+aQUbyMKTe2YvF5sh+wMJOiG8pHuxndjFl jr4SVsno6RQRF8CRsNnE2tEO9rcd69mtkRXQh1F7ezGDAwoGvuOMhtPWDYNR3LpW+adb qGrg== X-Gm-Message-State: AFqh2kq1wcEjSou6qDMH0D8RQfT71wF9qtPVs7sbnvuSCjN52wxrBOK8 koc9dcX+Y/rucBt9JSHaDGF0SShaXtzxkDtLhJGDqfPtiDfDs+tSeBU= X-Google-Smtp-Source: AMrXdXs9ga503SwE+09dmDEVZS1/XV2RvPbDoA7tJR1Y92okF1PYzLfNb1qZ9UTKSZ00MIBxwWsvnEHJ4Bii4h03Zso= X-Received: by 2002:a05:6e02:88d:b0:30f:5d21:e56 with SMTP id z13-20020a056e02088d00b0030f5d210e56mr1230055ils.192.1674557526609; Tue, 24 Jan 2023 02:52:06 -0800 (PST) MIME-Version: 1.0 References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-4-glider@google.com> In-Reply-To: <20221121112134.407362-4-glider@google.com> From: Alexander Potapenko Date: Tue, 24 Jan 2023 11:51:30 +0100 Message-ID: Subject: Re: [PATCH 4/5] fs: hfs: initialize fsdata in hfs_file_truncate() To: glider@google.com Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 21, 2022 at 12:21 PM Alexander Potapenko wrote: > > When aops->write_begin() does not initialize fsdata, KMSAN may report > an error passing the latter to aops->write_end(). > > Fix this by unconditionally initializing fsdata. > > Suggested-by: Eric Biggers > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Alexander Potapenko Dear FS maintainers, HFS/HFSPLUS are orphaned, can someone take this patch to their tree? Thanks in advance! (same for "fs: hfsplus: initialize fsdata in hfsplus_file_truncate()": https://lore.kernel.org/all/20221121112134.407362-5-glider@google.com/)