Date:   Tue, 24 Jan 2023 13:57:45 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Steen Hegelund <steen.hegelund@microchip.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, UNGLinuxDriver@microchip.com,
        Randy Dunlap <rdunlap@infradead.org>,
        Casper Andersson <casper.casan@gmail.com>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Nathan Huckleberry <nhuck@google.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Daniel Machon <daniel.machon@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Michael Walle <michael@walle.cc>
Subject: Re: [PATCH net-next v2 0/8] Adding Sparx5 IS0 VCAP support
Message-ID: <Y8+5qSgbSupca1bu@kadam>
References: <20230124104511.293938-1-steen.hegelund@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230124104511.293938-1-steen.hegelund@microchip.com>
Precedence: bulk

On Tue, Jan 24, 2023 at 11:45:03AM +0100, Steen Hegelund wrote:
> This provides the Ingress Stage 0 (IS0) VCAP (Versatile Content-Aware
> Processor) support for the Sparx5 platform.
> 
> The IS0 VCAP (also known in the datasheet as CLM) is a classifier VCAP that
> mainly extracts frame information to metadata that follows the frame in the
> Sparx5 processing flow all the way to the egress port.
> 
> The IS0 VCAP has 4 lookups and they are accessible with a TC chain id:
> 
> - chain 1000000: IS0 Lookup 0
> - chain 1100000: IS0 Lookup 1
> - chain 1200000: IS0 Lookup 2
> - chain 1300000: IS0 Lookup 3
> - chain 1400000: IS0 Lookup 4
> - chain 1500000: IS0 Lookup 5
> 
> Each of these lookups have their own port keyset configuration that decides
> which keys will be used for matching on which traffic type.
> 
> The IS0 VCAP has these traffic classifications:
> 
> - IPv4 frames
> - IPv6 frames
> - Unicast MPLS frames (ethertype = 0x8847)
> - Multicast MPLS frames (ethertype = 0x8847)
> - Other frame types than MPLS, IPv4 and IPv6
> 
> The IS0 VCAP has an action that allows setting the value of a PAG (Policy
> Association Group) key field in the frame metadata, and this can be used
> for matching in an IS2 VCAP rule.
> 
> This allow rules in the IS0 VCAP to be linked to rules in the IS2 VCAP.
> 
> The linking is exposed by using the TC "goto chain" action with an offset
> from the IS2 chain ids.
> 
> As an example a "goto chain 8000001" will use a PAG value of 1 to chain to
> a rule in IS2 Lookup 0.
> 
> Version History:
> ================
> v2      Added corrections suggested by Dan Carpenter.

Thanks!

regards,
dan carpenter