Date:   Tue, 24 Jan 2023 12:04:58 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        linux-pm@vger.kernel.org (open list:THERMAL),
        linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] thermal/drivers/armada: Use the
 thermal_zone_get_crit_temp()
Message-ID: <20230124120458.412fc528@xps-13>
In-Reply-To: <20230118222610.186088-1-daniel.lezcano@linaro.org>
References: <20230118222610.186088-1-daniel.lezcano@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Daniel,

daniel.lezcano@linaro.org wrote on Wed, 18 Jan 2023 23:26:10 +0100:

> The driver browses the trip point to find out the critical trip
> temperature. However the function thermal_zone_get_crit_temp() does
> already that, so the routine is pointless in the driver.
>=20
> Use thermal_zone_get_crit_temp() instead of inspecting all the trip
> points.
>=20
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/thermal/armada_thermal.c | 38 +++++++++++++-------------------
>  1 file changed, 15 insertions(+), 23 deletions(-)
>=20
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_th=
ermal.c
> index db040dbdaa0a..c6d51d8acbf0 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -784,34 +784,26 @@ static int armada_configure_overheat_int(struct arm=
ada_thermal_priv *priv,
>  					 int sensor_id)
>  {
>  	/* Retrieve the critical trip point to enable the overheat interrupt */
> -	struct thermal_trip trip;
> +	int temperature;
>  	int ret;
> -	int i;
> -
> -	for (i =3D 0; i < thermal_zone_get_num_trips(tz); i++) {
> -
> -		ret =3D thermal_zone_get_trip(tz, i, &trip);
> -		if (ret)
> -			return ret;
> -
> -		if (trip.type !=3D THERMAL_TRIP_CRITICAL)
> -			continue;
> -
> -		ret =3D armada_select_channel(priv, sensor_id);
> -		if (ret)
> -			return ret;
> =20
> -		armada_set_overheat_thresholds(priv, trip.temperature,
> -					       trip.hysteresis);
> -		priv->overheat_sensor =3D tz;
> -		priv->interrupt_source =3D sensor_id;
> +	ret =3D thermal_zone_get_crit_temp(tz, &temperature);
> +	if (ret)
> +		return ret;
> =20
> -		armada_enable_overheat_interrupt(priv);
> +	ret =3D armada_select_channel(priv, sensor_id);
> +	if (ret)
> +		return ret;
> =20
> -		return 0;
> -	}
> +	/*
> +	 * A critical temperature does not have a hysteresis
> +	 */

Makes sense.

Nit: I would actually put that comment in the commit log rather than
keeping it in the code, but whatever, that's a nice simplification.

> +	armada_set_overheat_thresholds(priv, temperature, 0);
> +	priv->overheat_sensor =3D tz;
> +	priv->interrupt_source =3D sensor_id;
> +	armada_enable_overheat_interrupt(priv);
> =20
> -	return -EINVAL;
> +	return 0;
>  }
> =20
>  static int armada_thermal_probe(struct platform_device *pdev)

LGTM so,

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miqu=C3=A8l